From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs/033: add golden output for CRC enaled filesystems
Date: Mon, 10 Feb 2014 12:51:05 +1100 [thread overview]
Message-ID: <20140210015105.GN13647@dastard> (raw)
In-Reply-To: <20140207174950.GB31464@infradead.org>
On Fri, Feb 07, 2014 at 09:49:50AM -0800, Christoph Hellwig wrote:
> On Wed, Feb 05, 2014 at 07:23:10PM +1100, Dave Chinner wrote:
> > diff --git a/common/filter b/common/filter
> > index 04d12c4..bb7fb33 100644
> > --- a/common/filter
> > +++ b/common/filter
> > @@ -152,6 +152,9 @@ _filter_mkfs()
> > if (/^\s+=\s+sectsz=(\d+)\s+attr=(\d+)/) {
> > print STDERR "sectsz=$1\nattr=$2\n";
> > }
> > + if (/^\s+=\s+crc=(\d)/) {
> > + print STDERR "crc=$1\n";
> > + }
>
> I think this variable is named way to genericly. And that probably
> applies to others as well.
>
> I'd suggest at least xfs_feature_crc or similar.
I can't say I like adding that prefix to the mkfs varaibles. I'll
change this one to something less generic, but I'm going to ignore
the others right now because changing them involves modifying 30+
tests....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-10 1:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 8:23 [PATCH] xfs/033: add golden output for CRC enaled filesystems Dave Chinner
2014-02-07 17:49 ` Christoph Hellwig
2014-02-10 1:51 ` Dave Chinner [this message]
2014-02-10 10:44 ` Christoph Hellwig
2014-02-10 10:55 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210015105.GN13647@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox