From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id A01167F3F for ; Sun, 9 Feb 2014 19:52:05 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 467BBAC005 for ; Sun, 9 Feb 2014 17:52:05 -0800 (PST) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id QQbYzd1BRfCN2PTw for ; Sun, 09 Feb 2014 17:52:03 -0800 (PST) Date: Mon, 10 Feb 2014 12:52:00 +1100 From: Dave Chinner Subject: Re: [PATCH] xfs/189: noattr2 invalid for CRC enabled filesystems Message-ID: <20140210015200.GO13647@dastard> References: <1391590000-7171-1-git-send-email-david@fromorbit.com> <20140207174754.GA31464@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140207174754.GA31464@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Fri, Feb 07, 2014 at 09:47:54AM -0800, Christoph Hellwig wrote: > On Wed, Feb 05, 2014 at 07:46:40PM +1100, Dave Chinner wrote: > > From: Dave Chinner > > > > Version 5 filesystems always have attr2 format enabled, and it > > cannot be turned off via the noattr2 mount option. As such, attempts > > to mount with noattr2 will be rejected and this causes cascading > > failures within the test. > > > > Hence detect if we've created a CRC enabled filesystem, and if this > > is the case _notrun the test. > > > > Signed-off-by: Dave Chinner > > --- > > tests/xfs/189 | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/tests/xfs/189 b/tests/xfs/189 > > index 27bfb63..addf7ce 100755 > > --- a/tests/xfs/189 > > +++ b/tests/xfs/189 > > @@ -241,7 +241,16 @@ _require_scratch > > unset SCRATCH_RTDEV > > unset SCRATCH_LOGDEV > > > > -_scratch_mkfs_xfs | _filter_mkfs 2>/dev/null > > +_scratch_mkfs_xfs | _filter_mkfs 2> $tmp.mkfs > > + > > +# check to see if we've made a CRC enabled filesystem. If so, > > +# we can't run the test because CRc enabled filesystems don't support > > +# noattr2 mount options and this will cause cascading failures that are > > +# impossible to filter. > > +. $tmp.mkfs > > +if [ $crc -eq 1 ]; then > > + _notrun "Filesystem CRCs enabled, noattr2 is not supported." > > +fi > > I really don't like opencoding this. Shouldn't we instead simplfy > pass a nocrc argument to _scratch_mkfs_xfs? No, that simply breaks old mkfs binaries. > Alternatively this magic should move into a helper. I'll roll it into a _requires_noattr2 helper. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs