From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs/189: noattr2 invalid for CRC enabled filesystems
Date: Mon, 10 Feb 2014 02:45:14 -0800 [thread overview]
Message-ID: <20140210104514.GB9840@infradead.org> (raw)
In-Reply-To: <20140210015200.GO13647@dastard>
On Mon, Feb 10, 2014 at 12:52:00PM +1100, Dave Chinner wrote:
> > I really don't like opencoding this. Shouldn't we instead simplfy
> > pass a nocrc argument to _scratch_mkfs_xfs?
>
> No, that simply breaks old mkfs binaries.
Well, we couldn't pass it unconditionally - the main idea is to hide
the magic and allow tests to easily create a noncrc filesystem.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-02-10 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 8:46 [PATCH] xfs/189: noattr2 invalid for CRC enabled filesystems Dave Chinner
2014-02-07 17:47 ` Christoph Hellwig
2014-02-10 1:52 ` Dave Chinner
2014-02-10 10:45 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210104514.GB9840@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox