From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs/033: add golden output for CRC enaled filesystems
Date: Mon, 10 Feb 2014 21:55:33 +1100 [thread overview]
Message-ID: <20140210105533.GX13997@dastard> (raw)
In-Reply-To: <20140210104426.GA9840@infradead.org>
On Mon, Feb 10, 2014 at 02:44:26AM -0800, Christoph Hellwig wrote:
> On Mon, Feb 10, 2014 at 12:51:05PM +1100, Dave Chinner wrote:
> > I can't say I like adding that prefix to the mkfs varaibles. I'll
> > change this one to something less generic, but I'm going to ignore
> > the others right now because changing them involves modifying 30+
> > tests....
>
> In that case let's keep the crc one without prefix for now. But I think
> introducing very generic variables into the environment implicitly is
> a bad idea and will bite us long term.
>
> Reluctantly:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
I renamed it earlier this afternoon to "_fs_has_crc" so that code
that checks it makes sense when you read it:
if [ $_fs_has_crc -eq 1 ]; then
.....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-02-10 10:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 8:23 [PATCH] xfs/033: add golden output for CRC enaled filesystems Dave Chinner
2014-02-07 17:49 ` Christoph Hellwig
2014-02-10 1:51 ` Dave Chinner
2014-02-10 10:44 ` Christoph Hellwig
2014-02-10 10:55 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210105533.GX13997@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox