From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 6/7] xfs: add xfs_verifier_error()
Date: Wed, 12 Feb 2014 09:27:14 +1100 [thread overview]
Message-ID: <20140211222714.GN13647@dastard> (raw)
In-Reply-To: <52FA7FEE.7040307@sandeen.net>
On Tue, Feb 11, 2014 at 01:54:22PM -0600, Eric Sandeen wrote:
> On 2/10/14, 9:14 PM, Eric Sandeen wrote:
> > We want to distinguish between corruption and CRC errors.
> > In addition, the full stack trace on verifier errors
> > seems less than helpful; it looks more like an oops than
> > corruption.
> >
> > Create a new function to specifically alert the user to
> > verifier errors, which can differentiate between
> > EFSCORRUPTED and CRC mismatches. It doesn't dump stack
> > unless the xfs error level is turned up high.
> >
> > Define a new error message (EFSBADCRC) to clearly identify
> > CRC errors. (Defined to EILSEQ, bad byte sequence)
>
> So, this now looks like:
>
> [259116.148375] XFS (loop0): Metadata corruption detected at xfs_sb_read_verify+0x118/0x150 [xfs], block 0x0. Unmount and run xfs_repair
> [259116.160345] ffff88022bab0000: 58 46 53 42 00 00 10 00 00 00 00 00 00 04 00 00 XFSB............
> [259116.169109] ffff88022bab0010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> [259116.177872] ffff88022bab0020: 73 df 07 64 a6 50 4d 5b 8d eb 2c 06 a1 ed e3 5c s..d.PM[..,....\
> [259116.186638] ffff88022bab0030: 00 00 00 00 00 02 00 04 00 00 00 00 00 00 00 80 ................
> [259116.195413] XFS (loop0): SB validate failed with error 117.
>
> when something fails.
>
> We should probably put a period after "xfs_repair" and also print
> one more line about what the hex spew means - "XFS (loop0): first
> 64 bytes of corrupted metadata buffer:" or something similar.
Yeah, I think we need to split that long line, too. i.e:
XFS (loop0): Metadata corruption detected at xfs_sb_read_verify+0x118/0x150 [xfs], block 0x0.
XFS (loop0): Please unmount and run xfs_repair.
XFS (loop0): First 64 bytes of corrupted metadata buffer contains:
ffff88022bab0000: 58 46 53 42 00 00 10 00 00 00 00 00 00 04 00 00 XFSB............
ffff88022bab0010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
ffff88022bab0020: 73 df 07 64 a6 50 4d 5b 8d eb 2c 06 a1 ed e3 5c s..d.PM[..,....\
ffff88022bab0030: 00 00 00 00 00 02 00 04 00 00 00 00 00 00 00 80 ................
XFS (loop0): SB validate failed with error 117.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-11 22:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 3:08 [PATCH 0/7 V2] xfs: verifier modification series Eric Sandeen
2014-02-11 3:09 ` [PATCH 1/7] xfs: limit superblock corruption errors to actual corruption Eric Sandeen
2014-02-11 3:09 ` [PATCH 2/7] xfs: skip pointless CRC updates after verifier failures Eric Sandeen
2014-02-11 3:10 ` [PATCH 3/7] xfs: Use defines for CRC offsets in all cases Eric Sandeen
2014-02-11 3:11 ` [PATCH 4/7] xfs: add helper for verifying checksums on xfs_bufs Eric Sandeen
2014-02-11 3:12 ` [PATCH 5/7] xfs: add helper for updating " Eric Sandeen
2014-02-11 3:14 ` [PATCH 6/7] xfs: add xfs_verifier_error() Eric Sandeen
2014-02-11 19:54 ` Eric Sandeen
2014-02-11 22:27 ` Dave Chinner [this message]
2014-02-14 3:56 ` Eric Sandeen
2014-02-11 3:15 ` [PATCH 7/7] xfs: modify verifiers to differentiate CRC failures from other errors Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211222714.GN13647@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox