From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/5] metadump: sanitise write_buf/index return values
Date: Fri, 14 Feb 2014 13:20:53 +1100 [thread overview]
Message-ID: <20140214022053.GQ13997@dastard> (raw)
In-Reply-To: <52FD1D38.1010006@sgi.com>
On Thu, Feb 13, 2014 at 01:30:00PM -0600, Mark Tinguely wrote:
> On 01/23/14 04:23, Dave Chinner wrote:
> >From: Dave Chinner<dchinner@redhat.com>
> >
> >Write_buf/write_index use confusing boolean values for return,
> >meaning that it's hard to tell what the correct error return is
> >supposed to be. Convert them to return zero on success or a
> >negative errno otherwise so that it's clear what the error case is.
> >
> >Signed-off-by: Dave Chinner<dchinner@redhat.com>
> >---
>
> Looks like this patch broke metadumps on some corrupted filesystems.
> This is a legacy filesystem that has zeroes overwriting the
> SB/AGF/AGI on AG 1/2/3:
>
>
> # xfs_metadump -wgo /dev/sda8 myfile.metadata
> xfs_agf_read_verify: XFS_CORRUPTION_ERROR
> xfs_metadump: cannot init perag data (117). Continuing anyway.
> Copied 64 of 64 inodes (0 of 4 AGs) xfs_agf_write_verify: XF
> S_CORRUPTION_ERROR
> write_buf: write verifer failed on bno 0x1100919/0x200
> (no output)
Where did it crash? Can you post the stack trace from gdb? Even
better, can you send a patch to fix the problem? ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-14 2:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 10:23 [PATCH 0/5] metadump: discontiguous directory block support Dave Chinner
2014-01-23 10:23 ` [PATCH 1/5] metadump: sanitise write_buf/index return values Dave Chinner
2014-02-03 11:08 ` Christoph Hellwig
2014-02-13 19:30 ` Mark Tinguely
2014-02-14 2:20 ` Dave Chinner [this message]
2014-02-14 19:51 ` Mark Tinguely
2014-02-14 20:54 ` Mark Tinguely
2014-01-23 10:23 ` [PATCH 2/5] metadump: support writing discontiguous io cursors Dave Chinner
2014-02-03 15:06 ` Christoph Hellwig
2014-01-23 10:23 ` [PATCH 3/5] metadump: separate single block objects from multiblock objects Dave Chinner
2014-02-03 15:09 ` Christoph Hellwig
2014-02-03 22:19 ` Dave Chinner
2014-01-23 10:23 ` [PATCH 4/5] metadump: walk single fsb objects a block at a time Dave Chinner
2014-02-03 15:43 ` Christoph Hellwig
2014-01-23 10:23 ` [PATCH 5/5] metadump: fully support discontiguous directory blocks Dave Chinner
2014-02-03 21:15 ` Christoph Hellwig
2014-02-03 3:19 ` [PATCH 0/5] metadump: discontiguous directory block support Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214022053.GQ13997@dastard \
--to=david@fromorbit.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox