From: Dave Chinner <david@fromorbit.com>
To: Shaun Gosse <sgosse@sgi.com>
Cc: Zachary Kotlarek <zach@kotlarek.com>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode
Date: Wed, 19 Feb 2014 11:13:07 +1100 [thread overview]
Message-ID: <20140219001307.GI13647@dastard> (raw)
In-Reply-To: <8D3FA7645C1CFC4E9E783D22B4C708644AA855@P-EXMB2-DC21.corp.sgi.com>
On Wed, Jan 15, 2014 at 05:31:34PM +0000, Shaun Gosse wrote:
> Looks good.
>
> Reviewed-by: Shaun Gosse <sgosse@sgi.com>
>
> Thanks again,
> -Shaun
>
> -----Original Message-----
> From: xfs-bounces@oss.sgi.com [mailto:xfs-bounces@oss.sgi.com] On Behalf Of Zachary Kotlarek
> Sent: Wednesday, January 15, 2014 11:23 AM
> To: xfs@oss.sgi.com
> Cc: Zachary Kotlarek
> Subject: [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode
>
> ---
> man/man8/mkfs.xfs.8 | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8 index 8184e10..e1c5cf7 100644
> --- a/man/man8/mkfs.xfs.8
> +++ b/man/man8/mkfs.xfs.8
> @@ -513,9 +513,11 @@ any power of 2 size from the filesystem block size up to 65536.
> .IP
> The
> .B version=ci
> -option enables ASCII only case-insensitive filename lookup and version
> +option enables ASCII-only case-insensitive filename lookup and version
> 2 directories. Filenames are case-preserving, that is, the names -are stored in directories using the case they were created with.
> +are stored in directories using the case they were created with. In
> +this mode non-ASCII file and directory names are not supported and are
> +likely to become inaccessible if used.
> .IP
> Note: Version 1 directories are not supported.
> .TP
> --
I missed this when it was posted and only just caught it. Sorry
about that.
I can't commit it without a Signed-off-by. Zachary, can you resned
this with a commit message indicating why the documentation change
is necessary and with a proper SOB on it?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-19 0:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 17:23 [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode Zachary Kotlarek
2014-01-15 17:23 ` Zachary Kotlarek
2014-01-15 17:31 ` Shaun Gosse
2014-02-19 0:13 ` Dave Chinner [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-01-15 9:09 Zachary Kotlarek
2014-01-15 15:43 ` Shaun Gosse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219001307.GI13647@dastard \
--to=david@fromorbit.com \
--cc=sgosse@sgi.com \
--cc=xfs@oss.sgi.com \
--cc=zach@kotlarek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox