* [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode
@ 2014-01-15 17:23 Zachary Kotlarek
2014-01-15 17:23 ` Zachary Kotlarek
0 siblings, 1 reply; 6+ messages in thread
From: Zachary Kotlarek @ 2014-01-15 17:23 UTC (permalink / raw)
To: xfs
Correct the typo noted by sgosse@sgi.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode
2014-01-15 17:23 [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode Zachary Kotlarek
@ 2014-01-15 17:23 ` Zachary Kotlarek
2014-01-15 17:31 ` Shaun Gosse
0 siblings, 1 reply; 6+ messages in thread
From: Zachary Kotlarek @ 2014-01-15 17:23 UTC (permalink / raw)
To: xfs; +Cc: Zachary Kotlarek
---
man/man8/mkfs.xfs.8 | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
index 8184e10..e1c5cf7 100644
--- a/man/man8/mkfs.xfs.8
+++ b/man/man8/mkfs.xfs.8
@@ -513,9 +513,11 @@ any power of 2 size from the filesystem block size up to 65536.
.IP
The
.B version=ci
-option enables ASCII only case-insensitive filename lookup and version
+option enables ASCII-only case-insensitive filename lookup and version
2 directories. Filenames are case-preserving, that is, the names
-are stored in directories using the case they were created with.
+are stored in directories using the case they were created with. In this
+mode non-ASCII file and directory names are not supported and are likely
+to become inaccessible if used.
.IP
Note: Version 1 directories are not supported.
.TP
--
1.7.2.3
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode
2014-01-15 17:23 ` Zachary Kotlarek
@ 2014-01-15 17:31 ` Shaun Gosse
2014-02-19 0:13 ` Dave Chinner
0 siblings, 1 reply; 6+ messages in thread
From: Shaun Gosse @ 2014-01-15 17:31 UTC (permalink / raw)
To: Zachary Kotlarek, xfs@oss.sgi.com
Looks good.
Reviewed-by: Shaun Gosse <sgosse@sgi.com>
Thanks again,
-Shaun
-----Original Message-----
From: xfs-bounces@oss.sgi.com [mailto:xfs-bounces@oss.sgi.com] On Behalf Of Zachary Kotlarek
Sent: Wednesday, January 15, 2014 11:23 AM
To: xfs@oss.sgi.com
Cc: Zachary Kotlarek
Subject: [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode
---
man/man8/mkfs.xfs.8 | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8 index 8184e10..e1c5cf7 100644
--- a/man/man8/mkfs.xfs.8
+++ b/man/man8/mkfs.xfs.8
@@ -513,9 +513,11 @@ any power of 2 size from the filesystem block size up to 65536.
.IP
The
.B version=ci
-option enables ASCII only case-insensitive filename lookup and version
+option enables ASCII-only case-insensitive filename lookup and version
2 directories. Filenames are case-preserving, that is, the names -are stored in directories using the case they were created with.
+are stored in directories using the case they were created with. In
+this mode non-ASCII file and directory names are not supported and are
+likely to become inaccessible if used.
.IP
Note: Version 1 directories are not supported.
.TP
--
1.7.2.3
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode
2014-01-15 17:31 ` Shaun Gosse
@ 2014-02-19 0:13 ` Dave Chinner
0 siblings, 0 replies; 6+ messages in thread
From: Dave Chinner @ 2014-02-19 0:13 UTC (permalink / raw)
To: Shaun Gosse; +Cc: Zachary Kotlarek, xfs@oss.sgi.com
On Wed, Jan 15, 2014 at 05:31:34PM +0000, Shaun Gosse wrote:
> Looks good.
>
> Reviewed-by: Shaun Gosse <sgosse@sgi.com>
>
> Thanks again,
> -Shaun
>
> -----Original Message-----
> From: xfs-bounces@oss.sgi.com [mailto:xfs-bounces@oss.sgi.com] On Behalf Of Zachary Kotlarek
> Sent: Wednesday, January 15, 2014 11:23 AM
> To: xfs@oss.sgi.com
> Cc: Zachary Kotlarek
> Subject: [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode
>
> ---
> man/man8/mkfs.xfs.8 | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8 index 8184e10..e1c5cf7 100644
> --- a/man/man8/mkfs.xfs.8
> +++ b/man/man8/mkfs.xfs.8
> @@ -513,9 +513,11 @@ any power of 2 size from the filesystem block size up to 65536.
> .IP
> The
> .B version=ci
> -option enables ASCII only case-insensitive filename lookup and version
> +option enables ASCII-only case-insensitive filename lookup and version
> 2 directories. Filenames are case-preserving, that is, the names -are stored in directories using the case they were created with.
> +are stored in directories using the case they were created with. In
> +this mode non-ASCII file and directory names are not supported and are
> +likely to become inaccessible if used.
> .IP
> Note: Version 1 directories are not supported.
> .TP
> --
I missed this when it was posted and only just caught it. Sorry
about that.
I can't commit it without a Signed-off-by. Zachary, can you resned
this with a commit message indicating why the documentation change
is necessary and with a proper SOB on it?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode
@ 2014-01-15 9:09 Zachary Kotlarek
2014-01-15 15:43 ` Shaun Gosse
0 siblings, 1 reply; 6+ messages in thread
From: Zachary Kotlarek @ 2014-01-15 9:09 UTC (permalink / raw)
To: xfs; +Cc: Zachary Kotlarek
---
man/man8/mkfs.xfs.8 | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
index 8184e10..7f965b0 100644
--- a/man/man8/mkfs.xfs.8
+++ b/man/man8/mkfs.xfs.8
@@ -513,9 +513,11 @@ any power of 2 size from the filesystem block size up to 65536.
.IP
The
.B version=ci
-option enables ASCII only case-insensitive filename lookup and version
+option enables ASCII-only case-insensitive filename lookup and version
2 directories. Filenames are case-preserving, that is, the names
-are stored in directories using the case they were created with.
+are stored in directories using the case they were created with. In this
+mode non-ASCII file and directory names are not supported are are likely
+to become inaccessible if used.
.IP
Note: Version 1 directories are not supported.
.TP
--
1.7.2.3
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode
2014-01-15 9:09 Zachary Kotlarek
@ 2014-01-15 15:43 ` Shaun Gosse
0 siblings, 0 replies; 6+ messages in thread
From: Shaun Gosse @ 2014-01-15 15:43 UTC (permalink / raw)
To: Zachary Kotlarek, xfs@oss.sgi.com
Just a typo, you have "are are" and I think you mean "and are".
Thanks for finding this, reporting, and making the patch! Definitely an important part of that option to document.
Cheers,
-Shaun
-----Original Message-----
From: xfs-bounces@oss.sgi.com [mailto:xfs-bounces@oss.sgi.com] On Behalf Of Zachary Kotlarek
Sent: Wednesday, January 15, 2014 3:10 AM
To: xfs@oss.sgi.com
Cc: Zachary Kotlarek
Subject: [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode
---
man/man8/mkfs.xfs.8 | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8 index 8184e10..7f965b0 100644
--- a/man/man8/mkfs.xfs.8
+++ b/man/man8/mkfs.xfs.8
@@ -513,9 +513,11 @@ any power of 2 size from the filesystem block size up to 65536.
.IP
The
.B version=ci
-option enables ASCII only case-insensitive filename lookup and version
+option enables ASCII-only case-insensitive filename lookup and version
2 directories. Filenames are case-preserving, that is, the names -are stored in directories using the case they were created with.
+are stored in directories using the case they were created with. In
+this mode non-ASCII file and directory names are not supported are are
+likely to become inaccessible if used.
.IP
Note: Version 1 directories are not supported.
.TP
--
1.7.2.3
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-19 0:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-15 17:23 [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode Zachary Kotlarek
2014-01-15 17:23 ` Zachary Kotlarek
2014-01-15 17:31 ` Shaun Gosse
2014-02-19 0:13 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2014-01-15 9:09 Zachary Kotlarek
2014-01-15 15:43 ` Shaun Gosse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox