From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: testing flink (aka linkat(..., AT_EMPTY_PATH)
Date: Fri, 21 Feb 2014 10:23:05 +1100 [thread overview]
Message-ID: <20140220232305.GT4916@dastard> (raw)
In-Reply-To: <20140220221245.GA32288@infradead.org>
On Thu, Feb 20, 2014 at 02:12:45PM -0800, Christoph Hellwig wrote:
> Turns out so far we aren't really do metadata operation in xfs_io
> and don't even have link/unlink. Should we starting adding these or
> where else should I start looking into adding support for exercising
> flink?
I think we need a tool that aggregates such functionality, otherwise
we just end up with a prolification of small helper utilities in
xfstests/src directory. There's the new renameat2 code that would
dearly love a helper function, reflink support woul be useful, etc.
And for O_TMPFILE, is just doesn't make sense to duplicate what
xfs_io does just so that flinkat() support can be tested.
Hence I'm happy to see such metadata operations added to xfs_io from
a functionality point of view. I also can't see any problems with
being able to integrate them into the command structure or the
source layout structure that xfs_io uses, so I'm not finding an
reason why we shouldn't be adding things like this...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-02-20 23:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 22:12 testing flink (aka linkat(..., AT_EMPTY_PATH) Christoph Hellwig
2014-02-20 23:23 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220232305.GT4916@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox