* testing flink (aka linkat(..., AT_EMPTY_PATH)
@ 2014-02-20 22:12 Christoph Hellwig
2014-02-20 23:23 ` Dave Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2014-02-20 22:12 UTC (permalink / raw)
To: xfs
Turns out so far we aren't really do metadata operation in xfs_io
and don't even have link/unlink. Should we starting adding these or
where else should I start looking into adding support for exercising
flink?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: testing flink (aka linkat(..., AT_EMPTY_PATH)
2014-02-20 22:12 testing flink (aka linkat(..., AT_EMPTY_PATH) Christoph Hellwig
@ 2014-02-20 23:23 ` Dave Chinner
0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2014-02-20 23:23 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On Thu, Feb 20, 2014 at 02:12:45PM -0800, Christoph Hellwig wrote:
> Turns out so far we aren't really do metadata operation in xfs_io
> and don't even have link/unlink. Should we starting adding these or
> where else should I start looking into adding support for exercising
> flink?
I think we need a tool that aggregates such functionality, otherwise
we just end up with a prolification of small helper utilities in
xfstests/src directory. There's the new renameat2 code that would
dearly love a helper function, reflink support woul be useful, etc.
And for O_TMPFILE, is just doesn't make sense to duplicate what
xfs_io does just so that flinkat() support can be tested.
Hence I'm happy to see such metadata operations added to xfs_io from
a functionality point of view. I also can't see any problems with
being able to integrate them into the command structure or the
source layout structure that xfs_io uses, so I'm not finding an
reason why we shouldn't be adding things like this...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-20 23:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-20 22:12 testing flink (aka linkat(..., AT_EMPTY_PATH) Christoph Hellwig
2014-02-20 23:23 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox