From: Dave Chinner <david@fromorbit.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstest generic/280: use waidpid instead of ugly sleep
Date: Mon, 24 Feb 2014 16:28:30 +1100 [thread overview]
Message-ID: <20140224052830.GL4317@dastard> (raw)
In-Reply-To: <1392972948-2463-1-git-send-email-dmonakhov@openvz.org>
On Fri, Feb 21, 2014 at 12:55:48PM +0400, Dmitry Monakhov wrote:
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
> tests/generic/280 | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/tests/generic/280 b/tests/generic/280
> index 815a2c5..7a2d1d0 100755
> --- a/tests/generic/280
> +++ b/tests/generic/280
> @@ -61,9 +61,10 @@ quotacheck -u -g $SCRATCH_MNT 2>/dev/null
> quotaon $SCRATCH_MNT 2>/dev/null
> xfs_freeze -f $SCRATCH_MNT
> setquota -u root 1 2 3 4 $SCRATCH_MNT &
> +pid=$!
> sleep 1
> xfs_freeze -u $SCRATCH_MNT
> -sleep 1
> +wait $pid
> umount $SCRATCH_DEV
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-02-24 5:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 8:55 [PATCH] xfstest generic/280: use waidpid instead of ugly sleep Dmitry Monakhov
2014-02-24 5:28 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224052830.GL4317@dastard \
--to=david@fromorbit.com \
--cc=dmonakhov@openvz.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox