* [PATCH] xfstest generic/280: use waidpid instead of ugly sleep
@ 2014-02-21 8:55 Dmitry Monakhov
2014-02-24 5:28 ` Dave Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Monakhov @ 2014-02-21 8:55 UTC (permalink / raw)
To: xfs; +Cc: Dmitry Monakhov
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
tests/generic/280 | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/tests/generic/280 b/tests/generic/280
index 815a2c5..7a2d1d0 100755
--- a/tests/generic/280
+++ b/tests/generic/280
@@ -61,9 +61,10 @@ quotacheck -u -g $SCRATCH_MNT 2>/dev/null
quotaon $SCRATCH_MNT 2>/dev/null
xfs_freeze -f $SCRATCH_MNT
setquota -u root 1 2 3 4 $SCRATCH_MNT &
+pid=$!
sleep 1
xfs_freeze -u $SCRATCH_MNT
-sleep 1
+wait $pid
umount $SCRATCH_DEV
# Failure comes in the form of a deadlock.
--
1.7.1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfstest generic/280: use waidpid instead of ugly sleep
2014-02-21 8:55 [PATCH] xfstest generic/280: use waidpid instead of ugly sleep Dmitry Monakhov
@ 2014-02-24 5:28 ` Dave Chinner
0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2014-02-24 5:28 UTC (permalink / raw)
To: Dmitry Monakhov; +Cc: xfs
On Fri, Feb 21, 2014 at 12:55:48PM +0400, Dmitry Monakhov wrote:
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
> tests/generic/280 | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/tests/generic/280 b/tests/generic/280
> index 815a2c5..7a2d1d0 100755
> --- a/tests/generic/280
> +++ b/tests/generic/280
> @@ -61,9 +61,10 @@ quotacheck -u -g $SCRATCH_MNT 2>/dev/null
> quotaon $SCRATCH_MNT 2>/dev/null
> xfs_freeze -f $SCRATCH_MNT
> setquota -u root 1 2 3 4 $SCRATCH_MNT &
> +pid=$!
> sleep 1
> xfs_freeze -u $SCRATCH_MNT
> -sleep 1
> +wait $pid
> umount $SCRATCH_DEV
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-24 5:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-21 8:55 [PATCH] xfstest generic/280: use waidpid instead of ugly sleep Dmitry Monakhov
2014-02-24 5:28 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox