[PATCH] xfstest generic/280: use waidpid instead of ugly sleep

[PATCH] xfstest generic/280: use waidpid instead of ugly sleep

[Dmitry Monakhov]

Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
 tests/generic/280 |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/tests/generic/280 b/tests/generic/280
index 815a2c5..7a2d1d0 100755
--- a/tests/generic/280
+++ b/tests/generic/280
@@ -61,9 +61,10 @@ quotacheck -u -g $SCRATCH_MNT 2>/dev/null
 quotaon $SCRATCH_MNT 2>/dev/null
 xfs_freeze -f $SCRATCH_MNT
 setquota -u root 1 2 3 4 $SCRATCH_MNT &
+pid=$!
 sleep 1
 xfs_freeze -u $SCRATCH_MNT
-sleep 1
+wait $pid
 umount $SCRATCH_DEV
 
 # Failure comes in the form of a deadlock.
-- 
1.7.1

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstest generic/280: use waidpid instead of ugly sleep

[Dave Chinner]

On Fri, Feb 21, 2014 at 12:55:48PM +0400, Dmitry Monakhov wrote:
> 
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
>  tests/generic/280 |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/tests/generic/280 b/tests/generic/280
> index 815a2c5..7a2d1d0 100755
> --- a/tests/generic/280
> +++ b/tests/generic/280
> @@ -61,9 +61,10 @@ quotacheck -u -g $SCRATCH_MNT 2>/dev/null
>  quotaon $SCRATCH_MNT 2>/dev/null
>  xfs_freeze -f $SCRATCH_MNT
>  setquota -u root 1 2 3 4 $SCRATCH_MNT &
> +pid=$!
>  sleep 1
>  xfs_freeze -u $SCRATCH_MNT
> -sleep 1
> +wait $pid
>  umount $SCRATCH_DEV

Looks fine.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs