From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: fix 300.out
Date: Mon, 24 Feb 2014 16:31:02 +1100 [thread overview]
Message-ID: <20140224053102.GM4317@dastard> (raw)
In-Reply-To: <53079F51.2050406@redhat.com>
On Fri, Feb 21, 2014 at 12:47:45PM -0600, Eric Sandeen wrote:
> This test was written before a solution was in place, I think,
> and so the expected output wasn't well tested.
>
> The test does a loop of sparse writes from 6 to 0, but the
> .out file expects 6 (not 7) extents. Fix it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/tests/xfs/300.out b/tests/xfs/300.out
> index ac03557..29ed771 100644
> --- a/tests/xfs/300.out
> +++ b/tests/xfs/300.out
> @@ -1,3 +1,3 @@
> QA output created by 300
> SCRATCH_MNT/300.test
> -extents before:6 after:1 DONE SCRATCH_MNT/300.test
> +extents before:7 after:1 DONE SCRATCH_MNT/300.test
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-02-24 5:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 18:47 [PATCH] xfstests: fix 300.out Eric Sandeen
2014-02-24 5:31 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224053102.GM4317@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox