* [PATCH] xfstests: fix 300.out
@ 2014-02-21 18:47 Eric Sandeen
2014-02-24 5:31 ` Dave Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2014-02-21 18:47 UTC (permalink / raw)
To: xfs-oss
This test was written before a solution was in place, I think,
and so the expected output wasn't well tested.
The test does a loop of sparse writes from 6 to 0, but the
.out file expects 6 (not 7) extents. Fix it.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/tests/xfs/300.out b/tests/xfs/300.out
index ac03557..29ed771 100644
--- a/tests/xfs/300.out
+++ b/tests/xfs/300.out
@@ -1,3 +1,3 @@
QA output created by 300
SCRATCH_MNT/300.test
-extents before:6 after:1 DONE SCRATCH_MNT/300.test
+extents before:7 after:1 DONE SCRATCH_MNT/300.test
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfstests: fix 300.out
2014-02-21 18:47 [PATCH] xfstests: fix 300.out Eric Sandeen
@ 2014-02-24 5:31 ` Dave Chinner
0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2014-02-24 5:31 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Fri, Feb 21, 2014 at 12:47:45PM -0600, Eric Sandeen wrote:
> This test was written before a solution was in place, I think,
> and so the expected output wasn't well tested.
>
> The test does a loop of sparse writes from 6 to 0, but the
> .out file expects 6 (not 7) extents. Fix it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/tests/xfs/300.out b/tests/xfs/300.out
> index ac03557..29ed771 100644
> --- a/tests/xfs/300.out
> +++ b/tests/xfs/300.out
> @@ -1,3 +1,3 @@
> QA output created by 300
> SCRATCH_MNT/300.test
> -extents before:6 after:1 DONE SCRATCH_MNT/300.test
> +extents before:7 after:1 DONE SCRATCH_MNT/300.test
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-24 5:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-21 18:47 [PATCH] xfstests: fix 300.out Eric Sandeen
2014-02-24 5:31 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox