From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V4] xfs: be honest about used inodes in statfs
Date: Tue, 25 Feb 2014 11:52:32 +1100 [thread overview]
Message-ID: <20140225005232.GV13647@dastard> (raw)
In-Reply-To: <530BE377.3050808@sandeen.net>
On Mon, Feb 24, 2014 at 06:27:35PM -0600, Eric Sandeen wrote:
> Because we have lazy counters, it's possible that we over-allocate
> inodes past the maxicount (imaxpct) limit.
>
> A previous commit,
>
> 2fe3366 xfs: ensure f_ffree returned by statfs() is non-negative
>
> stopped statfs from underflowing f_ffree in this case, but that
> only happened when we mis-reported f_files, capped at maxicount.
>
> Change statfs to report the actual number of inodes allocated,
> even if it is greater than maxicount. It's reality.
> Deal with it.
>
> Also rework code & rename vars for clarity after input from
> dchinner & bfoster.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> V2: code cleanup thanks to Brian
> V3: more cleanup thanks to Dave
> V4: Oh for crying out loud... (add maxicount test in else)
Looks good now!
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-02-25 0:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 22:12 [PATCH] xfs: be honest about used inodes in statfs Eric Sandeen
2014-02-24 16:01 ` Brian Foster
2014-02-24 20:38 ` Eric Sandeen
2014-02-24 23:10 ` [PATCH V2] " Eric Sandeen
2014-02-24 23:55 ` Brian Foster
2014-02-24 23:56 ` Dave Chinner
2014-02-25 0:02 ` Eric Sandeen
2014-02-25 0:15 ` [PATCH V3] " Eric Sandeen
2014-02-25 0:27 ` [PATCH V4] " Eric Sandeen
2014-02-25 0:52 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225005232.GV13647@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox