From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/6] shared/051: CRC enabled filesystems handle more than 25 ACLs
Date: Tue, 25 Feb 2014 14:09:11 -0800 [thread overview]
Message-ID: <20140225220911.GE5450@infradead.org> (raw)
In-Reply-To: <1393211175-30016-5-git-send-email-david@fromorbit.com>
On Mon, Feb 24, 2014 at 02:06:13PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> shared/051 fails on CRC enabled filesystems because it doesn't get
> an erro on setting the 26th ACL on a file. CRC enabled filesystems
> support more than 25, so there shoul dbe no error.
>
> Allow the test to pass on both non-CRC and CRC enabled filesystems
> by detecting the type of filesystem configuration and using that
> information to fake the error message so that the golden output
> match does not fail. We also need to filter the 26th ACL from the
> output otherwise that will cause failures, too.
I don't really like this - we'd better of defining a function saying how
many ACEs a filesystem supports and use that. Also I think the test for
these large ACLs should be a separate test from the other tests
currently in 051 as it's been causing a fair amount of issues in the
past with various filesystems.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-25 22:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 3:06 [PATCH 0/6] xfstests: fixes for CRCs and small devices Dave Chinner
2014-02-24 3:06 ` [PATCH 1/6] xfs/033: add golden output for CRC enabled filesystems Dave Chinner
2014-02-25 22:05 ` Christoph Hellwig
2014-02-24 3:06 ` [PATCH 2/6] xfs/189: noattr2 invalid " Dave Chinner
2014-02-25 22:05 ` Christoph Hellwig
2014-02-24 3:06 ` [PATCH 3/6] generic/003: ensure time changes between stat calls Dave Chinner
2014-02-25 22:06 ` Christoph Hellwig
2014-02-24 3:06 ` [PATCH 4/6] shared/051: CRC enabled filesystems handle more than 25 ACLs Dave Chinner
2014-02-25 22:09 ` Christoph Hellwig [this message]
2014-02-24 3:06 ` [PATCH 5/6] xfs/217: prevent enospc failures on small test devices Dave Chinner
2014-02-25 22:09 ` Christoph Hellwig
2014-02-24 3:06 ` [PATCH 6/6] xfs/167: need at least 10GB of scratch space to run Dave Chinner
2014-02-25 22:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225220911.GE5450@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox