From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_copy: accept XFS_ABTB_CRC_MAGIC
Date: Wed, 26 Feb 2014 17:02:26 +1100 [thread overview]
Message-ID: <20140226060226.GS13647@dastard> (raw)
In-Reply-To: <20140226020737.GA21877@infradead.org>
On Tue, Feb 25, 2014 at 06:07:37PM -0800, Christoph Hellwig wrote:
> On Tue, Feb 25, 2014 at 08:03:20PM -0600, Eric Sandeen wrote:
> > xfs_copy needs a fair bit of work for CRCs because it rewrites
> > UUIDs by default, but this change will get it working properly
> > with the "-d" (duplicate) option which keeps the same UUID.
>
> I don't think ASSERTs for user supplied data are a good idea, this
> should be some real error handling.
>
> > However, I wonder if we should fail CRC filesystems outright
> > for now if -d isn't specified, because it will invalidate every
> > CRC and generally make a mess of things...
>
> Yeah, for now it probably should be rejected.
>
> It would also be useful to have a list of such issues in an README.v5
> or TODO.v5 file in the xfsprogs tree.
Well, I thought we had just about got everything except for the
remaining repair cleanups and the logprint failure in xfs/295 up
until Eric mentioned UUIDs and xfs_copy/xfs_admin yesterday on IIRC.
I can't think of anything else that is needs to be finished for a
userspace release - I think that covers all the remaining xfstests
failures I'm seeing on crc enabled filesystems....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-26 6:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 2:03 [PATCH] xfs_copy: accept XFS_ABTB_CRC_MAGIC Eric Sandeen
2014-02-26 2:07 ` Christoph Hellwig
2014-02-26 6:02 ` Dave Chinner [this message]
2014-02-26 16:22 ` [PATCH V2] xfs_copy: band-aids for CRC filesystems Eric Sandeen
2014-02-26 20:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226060226.GS13647@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox