Re: [PATCH] xfs_copy: accept XFS_ABTB_CRC_MAGIC

Christoph Hellwig
2014-02-26T02:07:42Z

On Tue, Feb 25, 2014 at 08:03:20PM -0600, Eric Sandeen wrote:
> xfs_copy needs a fair bit of work for CRCs because it rewrites
> UUIDs by default, but this change will get it working properly
> with the "-d" (duplicate) option which keeps the same UUID.

I don't think ASSERTs for user supplied data are a good idea, this
should be some real error handling.

> However, I wonder if we should fail CRC filesystems outright
> for now if -d isn't specified, because it will invalidate every
> CRC and generally make a mess of things...

Yeah, for now it probably should be rejected.

It would also be useful to have a list of such issues in an README.v5
or TODO.v5 file in the xfsprogs tree.