From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/2] xfs_logprint: don't advance op counter in xlog_print_trans_icreate
Date: Thu, 27 Feb 2014 12:28:52 +1100 [thread overview]
Message-ID: <20140227012852.GY13647@dastard> (raw)
In-Reply-To: <530E91C8.1010207@sandeen.net>
On Wed, Feb 26, 2014 at 07:15:52PM -0600, Eric Sandeen wrote:
> xlog_print_trans_icreate is advancing the op counter
> "(*i)++" incorrectly; it only contains one region, and
> the loop which called it will properly advance the op
> once we're done.
>
> Found-by: Dave Chinner <dchinner@redhat.com>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/logprint/log_misc.c b/logprint/log_misc.c
> index 7070fa3..52f1e85 100644
> --- a/logprint/log_misc.c
> +++ b/logprint/log_misc.c
> @@ -810,7 +810,6 @@ xlog_print_trans_icreate(
>
> memmove(&icl_buf, *ptr, MIN(sizeof(struct xfs_icreate_log), len));
> icl = &icl_buf;
> - (*i)++;
> *ptr += len;
>
> /* handle complete header only */
*nod*. I'm pretty sure I introduced that bug - thanks for exposing
it and fixing it :)
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-02-27 1:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 1:00 [PATCH 0/2] xfs_logprint: Get xfstests/xfs/295 passing w/ CRCs Eric Sandeen
2014-02-27 1:13 ` [PATCH 1/2] xfs_logprint: Don't error out after split items lose context Eric Sandeen
2014-02-27 1:27 ` Dave Chinner
2014-02-27 1:15 ` [PATCH 2/2] xfs_logprint: don't advance op counter in xlog_print_trans_icreate Eric Sandeen
2014-02-27 1:28 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227012852.GY13647@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox