[PATCH] xfs_io: add missing break in O_TMPFILE case

[PATCH] xfs_io: add missing break in O_TMPFILE case

[Eric Sandeen]

Coverity spotted this.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

(I assume that -T isn't supposed to imply -x?)

diff --git a/io/init.c b/io/init.c
index fd1a52f..1e2690e 100644
--- a/io/init.c
+++ b/io/init.c
@@ -181,6 +181,7 @@ init(
 			break;
 		case 'T':
 			flags |= IO_TMPFILE;
+			break;
 		case 'x':
 			expert = 1;
 			break;

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_io: add missing break in O_TMPFILE case

[Christoph Hellwig]

On Thu, Feb 27, 2014 at 02:16:49PM -0600, Eric Sandeen wrote:
> Coverity spotted this.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> (I assume that -T isn't supposed to imply -x?)

It's not, thanks!

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_io: add missing break in O_TMPFILE case

[Dave Chinner]

On Thu, Feb 27, 2014 at 02:16:49PM -0600, Eric Sandeen wrote:
> Coverity spotted this.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> (I assume that -T isn't supposed to imply -x?)
> 
> diff --git a/io/init.c b/io/init.c
> index fd1a52f..1e2690e 100644
> --- a/io/init.c
> +++ b/io/init.c
> @@ -181,6 +181,7 @@ init(
>  			break;
>  		case 'T':
>  			flags |= IO_TMPFILE;
> +			break;
>  		case 'x':
>  			expert = 1;
>  			break;

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs