From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_growfs: don't grow data if only -m is specified
Date: Fri, 28 Feb 2014 12:19:01 +1100 [thread overview]
Message-ID: <20140228011901.GH30131@dastard> (raw)
In-Reply-To: <530FCA2C.8090204@redhat.com>
On Thu, Feb 27, 2014 at 05:28:44PM -0600, Eric Sandeen wrote:
> While writing an xfstest to check imaxpct behavior, I realized
> that xfs_growfs -m XXX /mnt/point will not only change
> imaxpct, but also grow the filesystem if it's not currently
> occupying the entire block device. This doesn't seem like
> the expected behavior, so split it out such that if only
> -m, and not -d, is specified, only the imaxpct will be
> changed.
>
> This is a change from previous behavior, but I think it
> satisfies the principle of least surprise...
Seems reasonable to me. Code looks good, too.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-02-28 1:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 23:28 [PATCH] xfs_growfs: don't grow data if only -m is specified Eric Sandeen
2014-02-28 1:19 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228011901.GH30131@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox