* [PATCH] xfstests: fix error msg in aio-dio-subblock-eof-read.c
@ 2014-03-04 5:24 Eric Sandeen
2014-03-04 5:43 ` [PATCH V2] " Eric Sandeen
0 siblings, 1 reply; 3+ messages in thread
From: Eric Sandeen @ 2014-03-04 5:24 UTC (permalink / raw)
To: xfs-oss
io_getevents returns the number of events; printing its
return as "bytes read" is ... wrong.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/src/aio-dio-regress/aio-dio-subblock-eof-read.c b/src/aio-dio-regress/aio-dio-subblock-eof-read.c
index a48841d..8f74cec 100644
--- a/src/aio-dio-regress/aio-dio-subblock-eof-read.c
+++ b/src/aio-dio-regress/aio-dio-subblock-eof-read.c
@@ -105,8 +107,8 @@ main(int argc, char **argv)
* are broken, we may very well see a result of 4k.
*/
if (ie.res != FILE_SIZE)
- fail("AIO read of last block in file returned %d bytes, "
- "expected %d\n", ret, FILE_SIZE);
+ fail("AIO read of last block in file returned %lu bytes, "
+ "expected %d\n", ie.res, FILE_SIZE);
printf("AIO read of last block in file succeeded.\n");
return 0;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH V2] xfstests: fix error msg in aio-dio-subblock-eof-read.c
2014-03-04 5:24 [PATCH] xfstests: fix error msg in aio-dio-subblock-eof-read.c Eric Sandeen
@ 2014-03-04 5:43 ` Eric Sandeen
2014-03-04 15:05 ` Brian Foster
0 siblings, 1 reply; 3+ messages in thread
From: Eric Sandeen @ 2014-03-04 5:43 UTC (permalink / raw)
To: Eric Sandeen, xfs-oss
io_getevents returns the number of events; printing its
return as "bytes read" is ... wrong.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
V2: print as signed so we can easily see errors returned
diff --git a/src/aio-dio-regress/aio-dio-subblock-eof-read.c b/src/aio-dio-regress/aio-dio-subblock-eof-read.c
index a48841d..8f74cec 100644
--- a/src/aio-dio-regress/aio-dio-subblock-eof-read.c
+++ b/src/aio-dio-regress/aio-dio-subblock-eof-read.c
@@ -105,8 +107,8 @@ main(int argc, char **argv)
* are broken, we may very well see a result of 4k.
*/
if (ie.res != FILE_SIZE)
- fail("AIO read of last block in file returned %d bytes, "
- "expected %d\n", ret, FILE_SIZE);
+ fail("AIO read of last block in file returned %ld bytes, "
+ "expected %d\n", ie.res, FILE_SIZE);
printf("AIO read of last block in file succeeded.\n");
return 0;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH V2] xfstests: fix error msg in aio-dio-subblock-eof-read.c
2014-03-04 5:43 ` [PATCH V2] " Eric Sandeen
@ 2014-03-04 15:05 ` Brian Foster
0 siblings, 0 replies; 3+ messages in thread
From: Brian Foster @ 2014-03-04 15:05 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Eric Sandeen, xfs-oss
On Mon, Mar 03, 2014 at 11:43:56PM -0600, Eric Sandeen wrote:
> io_getevents returns the number of events; printing its
> return as "bytes read" is ... wrong.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> V2: print as signed so we can easily see errors returned
>
Reviewed-by: Brian Foster <bfoster@redhat.com>
> diff --git a/src/aio-dio-regress/aio-dio-subblock-eof-read.c b/src/aio-dio-regress/aio-dio-subblock-eof-read.c
> index a48841d..8f74cec 100644
> --- a/src/aio-dio-regress/aio-dio-subblock-eof-read.c
> +++ b/src/aio-dio-regress/aio-dio-subblock-eof-read.c
> @@ -105,8 +107,8 @@ main(int argc, char **argv)
> * are broken, we may very well see a result of 4k.
> */
> if (ie.res != FILE_SIZE)
> - fail("AIO read of last block in file returned %d bytes, "
> - "expected %d\n", ret, FILE_SIZE);
> + fail("AIO read of last block in file returned %ld bytes, "
> + "expected %d\n", ie.res, FILE_SIZE);
>
> printf("AIO read of last block in file succeeded.\n");
> return 0;
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-04 15:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-04 5:24 [PATCH] xfstests: fix error msg in aio-dio-subblock-eof-read.c Eric Sandeen
2014-03-04 5:43 ` [PATCH V2] " Eric Sandeen
2014-03-04 15:05 ` Brian Foster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox