From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: fix use after free in inode_item_done()
Date: Wed, 5 Mar 2014 09:02:56 -0800 [thread overview]
Message-ID: <20140305170256.GB11667@infradead.org> (raw)
In-Reply-To: <5314E912.9080708@redhat.com>
On Mon, Mar 03, 2014 at 02:41:54PM -0600, Eric Sandeen wrote:
> Commit "3a19fb7 libxfs: stop caching inode structures"
> introduced a use after free.
I see the use after free, but I don't see how I would have introduced it
in that commit. Before that libxfs_iput already was freeing the inode
through the cache code, now we do it directly.
> @@ -739,12 +738,6 @@ ili_done:
> } else {
> libxfs_iput(ip, 0);
> }
> -
> - if (ip->i_itemp)
> - kmem_zone_free(xfs_ili_zone, ip->i_itemp);
> - else
> - ASSERT(0);
> - ip->i_itemp = NULL;
> }
Seems like inode_item_done should call into inode_item_unlock, which
factors the exact sequence we want into a nice helper.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-03-05 17:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 20:41 [PATCH] xfsprogs: fix use after free in inode_item_done() Eric Sandeen
2014-03-03 22:36 ` Dave Chinner
2014-03-03 22:48 ` Eric Sandeen
2014-03-03 22:55 ` Dave Chinner
2014-03-04 13:04 ` Roger Willcocks
2014-03-03 22:58 ` [PATCH V2] " Eric Sandeen
2014-03-03 23:09 ` Dave Chinner
2014-03-05 17:02 ` Christoph Hellwig [this message]
2014-03-05 17:19 ` [PATCH] " Eric Sandeen
[not found] ` <20140305223612.GA25639@infradead.org>
2014-03-05 22:40 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305170256.GB11667@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox