From: Dave Chinner <david@fromorbit.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: shared/051: update golden output to match the XFS max acl return errno
Date: Tue, 11 Mar 2014 07:53:05 +1100 [thread overview]
Message-ID: <20140310205305.GY6851@dastard> (raw)
In-Reply-To: <531D7897.2030800@oracle.com>
On Mon, Mar 10, 2014 at 04:32:23PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> Update the golden output to match the recently XFS return errno
> changes if hit the limits of maximum number of ACLs.
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> ---
> tests/shared/051.out | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/shared/051.out b/tests/shared/051.out
> index a871082..354ec6a 100644
> --- a/tests/shared/051.out
> +++ b/tests/shared/051.out
> @@ -280,7 +280,7 @@ mask::rwx
> other::rwx
>
> 1 above xfs acl max
> -chacl: cannot set access acl on "largeaclfile": Invalid argument
> +chacl: cannot set access acl on "largeaclfile": Argument list too long
That breaks the test on older kernels. Can you add a filter that
kills the "Invalid argument"/"Argument list too long" part of the
error message so the same golden output works for old and new
kernels?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-03-10 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 8:32 [PATCH] xfstests: shared/051: update golden output to match the XFS max acl return errno Jeff Liu
2014-03-10 8:35 ` Christoph Hellwig
2014-03-10 20:53 ` Dave Chinner [this message]
2014-03-11 12:48 ` Jeff Liu
2014-03-11 22:54 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310205305.GY6851@dastard \
--to=david@fromorbit.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox