From: Dave Chinner <david@fromorbit.com>
To: Kyle McMartin <kmcmarti@redhat.com>
Cc: sandeen@redhat.com, Eric Sandeen <sandeen@sandeen.net>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfsdump: don't assume getdents exists
Date: Sat, 22 Mar 2014 19:53:23 +1100 [thread overview]
Message-ID: <20140322085323.GC18572@destitution> (raw)
In-Reply-To: <20140322051205.GB8095@redacted.bos.redhat.com>
On Sat, Mar 22, 2014 at 01:12:05AM -0400, Kyle McMartin wrote:
> On Tue, Dec 10, 2013 at 08:46:08AM -0600, Eric Sandeen wrote:
> > Hey Kyle - were you going to do a V2 of this one?
> >
> > Just checking, thanks -
>
> i've got a pair of somewhat more substantial patches to fix the ifdef
> hell in this file, clean things up so it works on both getdents64 only
> and not, and then rips out the pre-2.4.1 getdents code.
>
> https://github.com/jkkm/xfsdump/commit/e156bcf06effbf5f2e26c53efb0ce028c4281f9e
> https://github.com/jkkm/xfsdump/commit/fff56b471220a8fa305b9158c4f8f0c7344c8fe6
>
> the latter looks quite a bit better... care to take a quick look and if
> they're decent, i'll submit them both.
Please just post the patches. People will comment on them on them
once you post them to the list...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-03-22 8:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 21:36 [PATCH] xfsdump: don't assume getdents exists Kyle McMartin
2013-11-06 22:48 ` Dave Chinner
2013-11-06 22:56 ` Kyle McMartin
2013-11-06 23:17 ` Dave Chinner
2013-11-06 23:19 ` Kyle McMartin
2013-11-07 6:58 ` Christoph Hellwig
2013-11-07 7:06 ` Christoph Hellwig
2013-12-10 14:46 ` Eric Sandeen
2013-12-10 19:50 ` Kyle McMartin
2014-03-22 5:12 ` Kyle McMartin
2014-03-22 8:53 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140322085323.GC18572@destitution \
--to=david@fromorbit.com \
--cc=kmcmarti@redhat.com \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox