From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: Kyle McMartin <kmcmarti@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] remove ancient sys_getdents code paths
Date: Tue, 25 Mar 2014 08:34:22 -0700 [thread overview]
Message-ID: <20140325153422.GA31551@infradead.org> (raw)
In-Reply-To: <20140325141553.GB18691@bfoster.bfoster>
On Tue, Mar 25, 2014 at 10:15:55AM -0400, Brian Foster wrote:
> I wonder if we could clean up the d_name offset checks to check it once
> and use a flag. Or use a signed type for size_diff and trigger off that.
> Just a thought, fwiw.
I'd just leave the code as-is and just remove the ifdef cruft. If
anyone is motivated enough to do real work on this area the callers
should simply be switched to readdir(3) and friends instead of
bikeshedding the current cruft. I just don't want to put even more load
on Kyle how just wants to get xfsdump running on arm64..
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-03-25 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 18:19 [PATCH 2/2] remove ancient sys_getdents code paths Kyle McMartin
2014-03-25 13:17 ` Christoph Hellwig
2014-03-25 14:15 ` Brian Foster
2014-03-25 15:34 ` Christoph Hellwig [this message]
2014-03-25 16:08 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325153422.GA31551@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=kmcmarti@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox