From: Kyle McMartin <kmcmarti@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Brian Foster <bfoster@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] remove ancient sys_getdents code paths
Date: Tue, 25 Mar 2014 12:08:08 -0400 [thread overview]
Message-ID: <20140325160808.GB28869@redacted.bos.redhat.com> (raw)
In-Reply-To: <20140325153422.GA31551@infradead.org>
On Tue, Mar 25, 2014 at 08:34:22AM -0700, Christoph Hellwig wrote:
> On Tue, Mar 25, 2014 at 10:15:55AM -0400, Brian Foster wrote:
> > I wonder if we could clean up the d_name offset checks to check it once
> > and use a flag. Or use a signed type for size_diff and trigger off that.
> > Just a thought, fwiw.
>
> I'd just leave the code as-is and just remove the ifdef cruft. If
> anyone is motivated enough to do real work on this area the callers
> should simply be switched to readdir(3) and friends instead of
> bikeshedding the current cruft. I just don't want to put even more load
> on Kyle how just wants to get xfsdump running on arm64..
>
Heh, actually, I started doing exactly that last night, after looking at
all the getdents_wrap callers...
That's probably a bit more... error-sensitive patch though, so I'd
prefer if at least 1/2 and/or 2/2 went in separately for debuggability.
--Kyle
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-03-25 16:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 18:19 [PATCH 2/2] remove ancient sys_getdents code paths Kyle McMartin
2014-03-25 13:17 ` Christoph Hellwig
2014-03-25 14:15 ` Brian Foster
2014-03-25 15:34 ` Christoph Hellwig
2014-03-25 16:08 ` Kyle McMartin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325160808.GB28869@redacted.bos.redhat.com \
--to=kmcmarti@redhat.com \
--cc=bfoster@redhat.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox