From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Brian Foster <bfoster@redhat.com>,
Eric Sandeen <sandeen@sandeen.net>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: fix buffer use after free on IO error
Date: Tue, 25 Mar 2014 10:44:17 -0700 [thread overview]
Message-ID: <20140325174417.GA23300@infradead.org> (raw)
In-Reply-To: <5331BF53.6000300@redhat.com>
On Tue, Mar 25, 2014 at 10:39:31AM -0700, Eric Sandeen wrote:
> so only _xfs_buf_ioend *might* pass something other than 0, and:
>
> File Function Line
> 0 xfs_buf.c xfs_buf_bio_end_io 1197 _xfs_buf_ioend(bp, 1);
> 1 xfs_buf.c xfs_buf_iorequest 1377 _xfs_buf_ioend(bp, bp->b_error ? 0 : 1);
>
> At least up until now that was always called with "1"
Right, _was_. But that changes to one always passing 1, and one passing
0 or one with your patch. Or one passing always 1 and one always
passing 0 with the suggestion from Brian and me. Either way we'd still
have versions passing 1.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-03-25 17:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-22 2:48 [PATCH] xfs: fix buffer use after free on IO error Eric Sandeen
2014-03-25 12:58 ` Brian Foster
2014-03-25 13:17 ` Christoph Hellwig
2014-03-25 16:05 ` Eric Sandeen
2014-03-25 17:25 ` Christoph Hellwig
2014-03-25 17:39 ` Eric Sandeen
2014-03-25 17:44 ` Christoph Hellwig [this message]
2014-03-25 18:08 ` Dave Chinner
2014-03-25 18:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325174417.GA23300@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox