From: Dave Chinner <david@fromorbit.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfstests: Make some shared tests generic
Date: Wed, 26 Mar 2014 09:45:46 +1100 [thread overview]
Message-ID: <20140325224546.GI18572@destitution> (raw)
In-Reply-To: <1395781911-13084-1-git-send-email-lczerner@redhat.com>
On Tue, Mar 25, 2014 at 10:11:50PM +0100, Lukas Czerner wrote:
> There are couple of tests in shared directory which really should be
> made generic, so move it. It is mostly collapse range tests, which
> really can be generic to make super we test every file system which adds
> collapse range support.
>
> Here is what we're moving in this commit.
>
> shared/001 -> generic/004
> shared/002 -> generic/009
> shared/003 -> generic/012
> shared/004 -> generic/016
> shared/005 -> generic/017
> shared/218 -> generic/018
> shared/305 -> generic/019
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> ---
....
> tests/shared/group | 8 ---
> 30 files changed, 865 insertions(+), 866 deletions(-)
> create mode 100755 tests/generic/004
> create mode 100644 tests/generic/004.out
> create mode 100644 tests/generic/009
> create mode 100644 tests/generic/009.out
> create mode 100644 tests/generic/012
> create mode 100644 tests/generic/012.out
> create mode 100644 tests/generic/016
> create mode 100644 tests/generic/016.out
> create mode 100644 tests/generic/017
> create mode 100644 tests/generic/017.out
Looks fine at a quick glance, but can you fix the modes on these
test files (009,012...) while you are moving them?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-03-25 22:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 21:11 [PATCH 1/2] xfstests: Make some shared tests generic Lukas Czerner
2014-03-25 21:11 ` [PATCH 2/2] xfstests: Make shared/243 ext4 specific Lukas Czerner
2014-03-25 22:45 ` Dave Chinner [this message]
2014-03-26 0:01 ` [PATCH 1/2] xfstests: Make some shared tests generic Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325224546.GI18572@destitution \
--to=david@fromorbit.com \
--cc=lczerner@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox