From: Brian Foster <bfoster@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [patch] xfs: extra semi-colon breaks a condition
Date: Fri, 28 Mar 2014 08:09:18 -0400 [thread overview]
Message-ID: <20140328120917.GA21961@bfoster.bfoster> (raw)
In-Reply-To: <20140328080313.GA25192@mwanda>
On Fri, Mar 28, 2014 at 11:03:13AM +0300, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
>
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index 98016b3..75df77d 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -659,10 +659,10 @@ xfs_check_page_type(
> if (type == XFS_IO_UNWRITTEN)
> return true;
> } else if (buffer_delay(bh)) {
> - if (type == XFS_IO_DELALLOC);
> + if (type == XFS_IO_DELALLOC)
> return true;
> } else if (buffer_dirty(bh) && buffer_mapped(bh)) {
> - if (type == XFS_IO_OVERWRITE);
> + if (type == XFS_IO_OVERWRITE)
> return true;
> }
>
Nice catch.
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-03-28 12:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 8:03 [patch] xfs: extra semi-colon breaks a condition Dan Carpenter
2014-03-28 12:09 ` Brian Foster [this message]
2014-03-29 1:56 ` Eric Sandeen
2014-03-29 2:08 ` Raphael S Carvalho
2014-04-03 19:36 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140328120917.GA21961@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox