From: Ben Myers <bpm@sgi.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: Linux Stable <stable@vger.kernel.org>,
XFS Mailing List <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: fix bad hash ordering
Date: Fri, 28 Mar 2014 14:07:58 -0500 [thread overview]
Message-ID: <20140328190758.GW1935@sgi.com> (raw)
In-Reply-To: <20140328173430.622616177@sgi.com>
On Fri, Mar 28, 2014 at 12:33:34PM -0500, Mark Tinguely wrote:
> Fix the fix directory "bad hash ordering" bug introduced in
> commit f5ea1100.
>
> Reported-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> Signed-off-by: Mark Tinguely <tinguely@sgi.com>
> ---
> A C program that generates this problem can be found at:
> http://oss.sgi.com/archives/xfs/2014-03/msg00373.html
>
> A xfstest for this bug is coming from Hannes Frederic Sowa.
>
> fs/xfs/xfs_da_btree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: b/fs/xfs/xfs_da_btree.c
> ===================================================================
> --- a/fs/xfs/xfs_da_btree.c
> +++ b/fs/xfs/xfs_da_btree.c
> @@ -1295,7 +1295,7 @@ xfs_da3_fixhashpath(
> node = blk->bp->b_addr;
> dp->d_ops->node_hdr_from_disk(&nodehdr, node);
> btree = dp->d_ops->node_tree_p(node);
> - if (be32_to_cpu(btree->hashval) == lasthash)
> + if (be32_to_cpu(btree[blk->index].hashval) == lasthash)
> break;
> blk->hashval = lasthash;
> btree[blk->index].hashval = cpu_to_be32(lasthash);
Looks good to me.
Reviewed-by: Ben Myers <bpm@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-03-28 19:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 17:33 [PATCH] xfs: fix bad hash ordering Mark Tinguely
2014-03-28 19:07 ` Ben Myers [this message]
2014-03-31 0:10 ` Dave Chinner
2014-03-31 0:35 ` Eric Sandeen
2014-03-31 16:42 ` Mark Tinguely
2014-03-31 21:40 ` Dave Chinner
2014-04-01 2:22 ` Mark Tinguely
2014-04-01 22:03 ` Dave Chinner
2014-04-07 19:00 ` [PATCH] xfsprogs: fix directory hash ordering bug Mark Tinguely
2014-04-08 8:56 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140328190758.GW1935@sgi.com \
--to=bpm@sgi.com \
--cc=stable@vger.kernel.org \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).