Re: [Lsf] [PATCH] xfstests-bld: Simplify determination of number of CPUs in build-all

Eric Sandeen
2014-04-03T21:46:30Z

On 4/3/14, 1:21 PM, Andy Lutomirski wrote:
> On Thu, Apr 3, 2014 at 12:06 PM, Eric Sandeen <sandeen@redhat.com> wrote:

...

>>> The various test scripts do need to be able to find the device where
>>> the file system lives, and parsing /etc/fstab would be awkward. So if
>>> your comment is that either the /etc/fstab entry shouldn't be
>>> required, or the xfstests runtime environment should be able to derive
>>> $SCRATCH_DEV automatically from $SCRATCH_MNT, or vice versa, instead
>>
>> I guess I don't know why you'd expect to derive one from the other...
>
> Sigh.
>
> If $SCRATCH_MNT is specified, then the line in /etc/fstab is
> unnecessary. If $SCRATCH_MNT is not specified, then /etc/fstab will
> do the trick.
>
> What does not work is specifying $SCRATCH_DIR [sic] but not adding an
> fstab entry. Oops.

Oh, I see.

I'd never really thought about xfstests devices as "part of the system" -
since they're constantly scribbled on, re-made, etc, and managed wholly
by xfstests (at least the scratch device) - so the notion of using fstab
was just outside my realm of expected behaviors. :)

-Eric