Re: [Lsf] [PATCH] xfstests-bld: Simplify determination of number of CPUs in build-all

Dave Chinner
2014-04-03T21:20:11Z

On Thu, Apr 03, 2014 at 03:30:40PM -0400, Theodore Ts'o wrote:
> On Thu, Apr 03, 2014 at 01:06:40PM -0600, Eric Sandeen wrote:
> > On 4/3/14, 11:35 AM, Theodore Ts'o wrote:
> >
> > >> - There's an undocumented way to write results outside the source
> > >> tree called RESULT_BASE. It would be great if it were documented and
> > >> spelled consistently.
> >
> > I'm not actually certain that it was intended to be used this way.
> > See 1686f9ab "xfstests: Introduce a results directory"
> > which explains just where this variable came from and what it's
> > for...
>
> The last paragraph states of the git description states:
>
> This is the first (small) step in being able to store test results
> in an external location for archival/data mining purposes.
>
> The question I suppose is whether storing the results in an external
> location is something that should be xfstests' responsibility, or of
> the test harnesses that call xfstests.

The idea is that the external test harnesses can set up a
destination directory for the results (i.e. RESULT_BASE) and
xfstests will write all results into that directory. i.e. setting
up a results store and managing it is something that is currently
done external to xfstests.

Managing a results store is complex and nobody has sent patches to
do this in a generic way, so all we currently have is a mechanism to
enable such functionality. Patches welcome!

> I suspect that since there are
> so many different ways people might want to archive the results, it
> does make sense for the test harnesses to handle this job, but I
> wouldn't want to "presume" on anything that the xfstests developers
> might choose to do....

ROWR! :)

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com