From: Kyle McMartin <kmcmarti@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfsdump: getdents.c: clean up ifdef-hell around sys_getdents
Date: Tue, 8 Apr 2014 09:35:54 -0400 [thread overview]
Message-ID: <20140408133554.GD12397@redacted.bos.redhat.com> (raw)
In-Reply-To: <20140408003311.GH27017@dastard>
On Tue, Apr 08, 2014 at 10:33:11AM +1000, Dave Chinner wrote:
> On Mon, Mar 24, 2014 at 02:19:07PM -0400, Kyle McMartin wrote:
> > Remove the ifdef-hell imported from glibc around getdents64. Everything
> > since 2.4.1 supports things properly and this seems like a sensible
> > clean up, so lets just assume it exists and handle it by falling back
> > if not.
> >
> > Additionally, if the old getdents syscall doesn't exist, just stub out
> > the actual syscall and return ENOSYS.
> >
> > ---
>
> Kyle, these two patches are missing your SOB. I'm going to assume
> you wrote this yourself (given the history, it's a fair bet :)
> and add them in - let me know if then assumption is wrong so I can
> correct it.
That's correct, my apologies for not including it on the submission.
Thanks very much Dave.
--Kyle
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-04-08 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 18:19 [PATCH 1/2] xfsdump: getdents.c: clean up ifdef-hell around sys_getdents Kyle McMartin
2014-04-08 0:33 ` Dave Chinner
2014-04-08 13:35 ` Kyle McMartin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140408133554.GD12397@redacted.bos.redhat.com \
--to=kmcmarti@redhat.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox