From: Dave Chinner <david@fromorbit.com>
To: Ming Chen <v.mingchen@gmail.com>
Cc: Erez Zadok <ezk@fsl.cs.sunysb.edu>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstest: log operations properly to generic/001.full
Date: Wed, 9 Apr 2014 10:08:09 +1000 [thread overview]
Message-ID: <20140409000809.GN27017@dastard> (raw)
In-Reply-To: <CAG+wggbx13tnYB=J8q83oK72td2VV=V1Fg=-q3JnZb=5tCgCSQ@mail.gmail.com>
On Sat, Apr 05, 2014 at 01:52:43AM -0400, Ming Chen wrote:
> Part of the operations were written to 001.full from the awk script, while the
> rest were piped to 001.full using tee. The resultant 001.full did not reflect
> what are really performed. This makes debugging difficult.
>
> Signed-off-by: Ming Chen <v.mingchen@gmail.com>
This patch causes generic/001 to fail because it pushes all the
debug into the output file as well as the generic/001.full file.
diff -u tests/generic/001.out /home/dave/src/xfstests-dev/results//generic/001.out.bad
--- tests/generic/001.out 2014-01-20 16:57:33.000000000 +1100
+++ /home/dave/src/xfstests-dev/results//generic/001.out.bad 2014-04-09 09:58:34.000000000 +1000
@@ -1,9 +1,1189 @@
QA output created by 001
cleanup
setup ....................................
-iter 1 chain ... check ....................................
-iter 2 chain ... check ....................................
-iter 3 chain ... check ....................................
-iter 4 chain ... check ....................................
-iter 5 chain ... check ....................................
+iter 1 chain ... 2320100 sub/e.0
+2320101 sub/g.0
+2320102 sub/m00.0
+2320103 sub/b.0
+2320104 sub/d00.0
+2320105 sub/c.0
+2320106 sub/l00.0
+2320107 sub/c.1
.....
I'm going to drop this patch because it breaks a previously working
test....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-04-09 0:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-05 5:52 [PATCH] xfstest: log operations properly to generic/001.full Ming Chen
2014-04-08 23:43 ` Dave Chinner
2014-04-09 0:09 ` Ming Chen
2014-04-09 0:08 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409000809.GN27017@dastard \
--to=david@fromorbit.com \
--cc=ezk@fsl.cs.sunysb.edu \
--cc=v.mingchen@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox