From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] ext4/306: disable 64bit feature too
Date: Fri, 11 Apr 2014 10:12:35 +1000 [thread overview]
Message-ID: <20140411001235.GB15995@dastard> (raw)
In-Reply-To: <1397044147-15727-1-git-send-email-eguan@redhat.com>
On Wed, Apr 09, 2014 at 07:49:07PM +0800, Eryu Guan wrote:
> mke2fs ext4 without extent feature will fail if 64bit feature is
> enabled in mke2fs.conf
>
> mke2fs 1.42.9 (28-Dec-2013)
> Extents MUST be enabled for a 64-bit filesystem. Pass -O extents to rectify.
>
> So disable 64bit feature together with extent explicitly.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
> tests/ext4/306 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/ext4/306 b/tests/ext4/306
> index 9559cf2..fd50b0e 100755
> --- a/tests/ext4/306
> +++ b/tests/ext4/306
> @@ -48,7 +48,7 @@ _require_scratch
> rm -f $seqres.full
>
> # Make a small ext4 fs with extents disabled & mount it
> -yes | mkfs.ext4 -O ^extents $SCRATCH_DEV 512m >> $seqres.full 2>&1
> +yes | mkfs.ext4 -O ^extents,^64bit $SCRATCH_DEV 512m >> $seqres.full 2>&1
> _scratch_mount || _fail "couldn't mount fs"
>
> # Create a small non-extent-based file
> --
> 1.9.0
Looks fine to me, but you should CC ext4 test changes to
linux-ext4@vger.kernel.org as well so that the ext4 developers can
review such changes are well...
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-04-11 0:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 11:49 [PATCH] ext4/306: disable 64bit feature too Eryu Guan
2014-04-11 0:12 ` Dave Chinner [this message]
2014-04-11 3:23 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140411001235.GB15995@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox