From: Dave Chinner <david@fromorbit.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fix specifying configuration value with equality sign
Date: Fri, 11 Apr 2014 10:14:10 +1000 [thread overview]
Message-ID: <20140411001410.GC15995@dastard> (raw)
In-Reply-To: <1397123737-3478-1-git-send-email-lczerner@redhat.com>
On Thu, Apr 10, 2014 at 11:55:37AM +0200, Lukas Czerner wrote:
> Currently there is a problem with parse_config_section() when the
> configuration value contains equality sign like this for example:
>
> MOUNT_OPTIONS="-o data=journal"
>
> the result will be
>
> export MOUNT_OPTIONS="-o data="journal"
>
> which is not going to work. The reason is that the expression used to
> parse the configuration options uses greedy matching '.*'. Fix this by
> using non greedy expression to match the first equality sign '[^=]'.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
It would probably be a good idea to comment what the sed line noise
is actually doing, so it's easier to understand in future...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-04-11 0:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 9:55 [PATCH] xfstests: fix specifying configuration value with equality sign Lukas Czerner
2014-04-11 0:14 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140411001410.GC15995@dastard \
--to=david@fromorbit.com \
--cc=lczerner@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox