From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 72F567F7E for ; Fri, 11 Apr 2014 02:39:40 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 16C74AC002 for ; Fri, 11 Apr 2014 00:39:40 -0700 (PDT) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id jLDzL36QMGwzkNpN (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Fri, 11 Apr 2014 00:39:39 -0700 (PDT) Date: Fri, 11 Apr 2014 00:39:39 -0700 From: Christoph Hellwig Subject: Re: [PATCH] xfs: wrong error sign conversion during failed DIO writes Message-ID: <20140411073939.GA11314@infradead.org> References: <1397191575-2144-1-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1397191575-2144-1-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Fri, Apr 11, 2014 at 02:46:15PM +1000, Dave Chinner wrote: > From: Dave Chinner > > We negate the error value being returned from a generic function > incorrectly. The code path that it is running in returned negative > errors, so there is no need to negate it to get the correct error > signs here. > > This was uncovered by generic/019. Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs