From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/9] xfs: split xfs_bmap_btalloc_nullfb
Date: Mon, 14 Apr 2014 09:03:25 +0200 [thread overview]
Message-ID: <20140414070325.GA22490@lst.de> (raw)
In-Reply-To: <20140414015544.GH27694@dastard>
On Mon, Apr 14, 2014 at 11:55:44AM +1000, Dave Chinner wrote:
> > +static void
> > +xfs_bmap_fix_args(
> > + struct xfs_bmalloca *ap,
> > + struct xfs_alloc_arg *args,
> > + xfs_extlen_t *blen,
> > + int notinit)
>
> Not a big fan of the "fix_args" name here. What it's actually doing
> is setting the minimum allocation length. Also, it could return the
> minimum length rather than set it inside the function, and pass
> blen by value rather than reference as it isn't modified in the
> function...
Sure. A any good suggestion for a name?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-04-14 7:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-12 8:01 filestream allocator rewrite Christoph Hellwig
2014-04-12 8:01 ` [PATCH 1/9] xfs: don't try to use the filestream allocator for metadata allocations Christoph Hellwig
2014-04-12 8:01 ` [PATCH 2/9] xfs: split xfs_bmap_btalloc_nullfb Christoph Hellwig
2014-04-14 1:55 ` Dave Chinner
2014-04-14 7:03 ` Christoph Hellwig [this message]
2014-04-14 7:17 ` Dave Chinner
2014-04-12 8:01 ` [PATCH 3/9] xfs: handle duplicate entries in xfs_mru_cache_insert Christoph Hellwig
2014-04-12 8:01 ` [PATCH 4/9] xfs: embedd mru_elem into parent structure Christoph Hellwig
2014-04-12 8:01 ` [PATCH 5/9] xfs: remove XFS_IFILESTREAM Christoph Hellwig
2014-04-12 8:02 ` [PATCH 6/9] xfs: rewrite the filestream allocator using the dentry cache Christoph Hellwig
2014-04-12 8:02 ` [PATCH 7/9] xfs: don't create a slab cache for filestream items Christoph Hellwig
2014-04-12 8:02 ` [PATCH 8/9] xfs: remove xfs_filestream_associate Christoph Hellwig
2014-04-12 8:02 ` [PATCH 9/9] xfs: add filestream allocator tracepoints Christoph Hellwig
2014-04-14 2:23 ` filestream allocator rewrite Dave Chinner
2014-04-22 21:06 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414070325.GA22490@lst.de \
--to=hch@lst.de \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).