From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 546797F3F for ; Tue, 15 Apr 2014 16:54:15 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 4556F8F8037 for ; Tue, 15 Apr 2014 14:54:15 -0700 (PDT) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id A3NvVc1FlPl7vyTF for ; Tue, 15 Apr 2014 14:54:13 -0700 (PDT) Date: Wed, 16 Apr 2014 07:53:59 +1000 From: Dave Chinner Subject: Re: [PATCH 6/9] repair: report AG btree verifier errors Message-ID: <20140415215359.GP15995@dastard> References: <1397550301-31883-1-git-send-email-david@fromorbit.com> <1397550301-31883-7-git-send-email-david@fromorbit.com> <20140415194048.GD3470@laptop.bfoster> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140415194048.GD3470@laptop.bfoster> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Brian Foster Cc: xfs@oss.sgi.com On Tue, Apr 15, 2014 at 03:40:48PM -0400, Brian Foster wrote: > On Tue, Apr 15, 2014 at 06:24:58PM +1000, Dave Chinner wrote: > > From: Dave Chinner > > > > When we scan the filesystem freespace and inode maps in phase 2, we > > don't report CRC errors that are found. We don't really care from a > > repair perspective, because the trees are completely rebuilt from > > the ground up in phase 5, but froma checking perspective we need to > > inform the user that we found inconsistencies. > > > > Signed-off-by: Dave Chinner > > --- > > repair/scan.c | 27 ++++++++++++++++++++++++--- > > 1 file changed, 24 insertions(+), 3 deletions(-) > > > > diff --git a/repair/scan.c b/repair/scan.c > > index 6c43474..75b4b70 100644 > > --- a/repair/scan.c > > +++ b/repair/scan.c > > @@ -82,6 +82,12 @@ scan_sbtree( > > do_error(_("can't read btree block %d/%d\n"), agno, root); > > return; > > } > > + if (bp->b_error == EFSBADCRC || bp->b_error == EFSCORRUPTED) { > > + do_warn(_("btree block %d/%d is suspect, error %d\n"), > > + agno, root, bp->b_error); > > + suspect = 1; > > + } > > + > > (*func)(XFS_BUF_TO_BLOCK(bp), nlevels - 1, root, agno, suspect, > > isroot, magic, priv); > > libxfs_putbuf(bp); > > @@ -123,6 +129,7 @@ scan_lbtree( > > xfs_buf_t *bp; > > int err; > > int dirty = 0; > > + bool badcrc = false; > > > > bp = libxfs_readbuf(mp->m_dev, XFS_FSB_TO_DADDR(mp, root), > > XFS_FSB_TO_BB(mp, 1), 0, ops); > > @@ -132,14 +139,25 @@ scan_lbtree( > > XFS_FSB_TO_AGBNO(mp, root)); > > return(1); > > } > > + > > + /* > > + * only check for bad CRC here - caller will determine if there > > + * is a corruption or not and whether it got corrected and so needs > > + * writing back. CRC errors always imply we need to write the block. > > + */ > > + if (bp->b_error == EFSBADCRC) { > > + do_warn(_("btree block %d/%d is suspect, error %d\n"), > > + XFS_FSB_TO_AGNO(mp, root), > > + XFS_FSB_TO_AGBNO(mp, root), bp->b_error); > > + badcrc = true; > > + } > > + > > err = (*func)(XFS_BUF_TO_BLOCK(bp), nlevels - 1, > > type, whichfork, root, ino, tot, nex, blkmapp, > > bm_cursor, isroot, check_dups, &dirty, > > magic); > > > > - ASSERT(dirty == 0 || (dirty && !no_modify)); > > - > > Here we remove the dirty assert, but don't change the semantics of dirty > (we use badcrc). Yeah, I went back and changed the mechanism for correcting pure CRC errors not to use the dirty flag. I'll re-instate the assert... Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs