From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 14C9E7F3F for ; Tue, 15 Apr 2014 19:32:00 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id E597E304077 for ; Tue, 15 Apr 2014 17:31:59 -0700 (PDT) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id q6fGACaODZA3LZN5 for ; Tue, 15 Apr 2014 17:31:57 -0700 (PDT) Date: Wed, 16 Apr 2014 10:31:05 +1000 From: Dave Chinner Subject: Re: [xfstests PATCH] renameat2 syscall: turn EEXIST into ENOTEMPTY Message-ID: <20140416003105.GX15995@dastard> References: <20140414104953.GE10187@tucsk.piliscsaba.szeredi.hu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140414104953.GE10187@tucsk.piliscsaba.szeredi.hu> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Miklos Szeredi Cc: xfs@oss.sgi.com On Mon, Apr 14, 2014 at 12:49:53PM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi > > XFS is returning EEXIST rather than ENOTEMPTY for several of > these rename tests. The rename man page says this about the errors: > > ENOTEMPTY or EEXIST > newpath is a nonempty directory, that is, contains > entries other than "." and "..". > > Which implies that both errors are valid and so the test should pass > in either case. > > Signed-off-by: Miklos Szeredi looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs