From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 8/9] repair: handle remote sylmlink CRC errors
Date: Wed, 16 Apr 2014 09:23:56 -0400 [thread overview]
Message-ID: <20140416132356.GB4180@laptop.bfoster> (raw)
In-Reply-To: <1397550301-31883-9-git-send-email-david@fromorbit.com>
On Tue, Apr 15, 2014 at 06:25:00PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
Just a couple nits... otherwise it looks good to me. There's a typo in
the patch subject...
> We can't really repair broken symlink buffer contents, but we can at
> least warn about it and correct the CRC error so the symlink is
> again readable.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> repair/dinode.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/repair/dinode.c b/repair/dinode.c
> index b086bec..51863c4 100644
> --- a/repair/dinode.c
> +++ b/repair/dinode.c
> @@ -1254,6 +1254,7 @@ process_symlink_remote(
> while (pathlen > 0) {
> int blk_cnt = 1;
> int byte_cnt;
> + int dirty = 0;
>
> fsbno = blkmap_get(blkmap, i);
> if (fsbno == NULLDFSBNO) {
> @@ -1284,6 +1285,12 @@ _("cannot read inode %" PRIu64 ", file block %d, disk block %" PRIu64 "\n"),
> lino, i, fsbno);
> return 1;
> }
> + if (bp->b_error == EFSBADCRC) {
> + do_warn(
> +_("Bad symlink buffer CRC block %" PRIu64 ", inode %" PRIu64 ".\n"
"Bad symlink buffer CRC, block ..."
... and sticking a comma or some separator in that message makes it a
little easier to read, IMO.
Brian
> + "Correcting CRC, but symlink may be bad.\n"), fsbno, lino);
> + dirty = 1;
> + }
>
> byte_cnt = XFS_SYMLINK_BUF_SPACE(mp, byte_cnt);
> byte_cnt = MIN(pathlen, byte_cnt);
> @@ -1307,7 +1314,10 @@ _("bad symlink header ino %" PRIu64 ", file block %d, disk block %" PRIu64 "\n")
> offset += byte_cnt;
> i++;
>
> - libxfs_putbuf(bp);
> + if (dirty)
> + libxfs_writebuf(bp, 0);
> + else
> + libxfs_putbuf(bp);
> }
> return 0;
> }
> --
> 1.9.0
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-04-16 13:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 8:24 [PATCH 0/9] xfs_db, xfs_repair: improve CRC error detection Dave Chinner
2014-04-15 8:24 ` [PATCH 1/9] db: don't claim unchecked CRCs are correct Dave Chinner
2014-04-21 7:00 ` Christoph Hellwig
2014-04-21 23:13 ` Dave Chinner
2014-04-15 8:24 ` [PATCH 2/9] db: verify buffer on type change Dave Chinner
2014-04-21 7:02 ` Christoph Hellwig
2014-04-21 23:14 ` Dave Chinner
2014-04-15 8:24 ` [PATCH 3/9] repair: ensure prefetched buffers have CRCs validated Dave Chinner
2014-04-15 19:40 ` Brian Foster
2014-04-15 21:46 ` Dave Chinner
2014-04-15 22:06 ` Brian Foster
2014-04-16 0:41 ` Dave Chinner
2014-04-15 8:24 ` [PATCH 4/9] repair: detect and correct CRC errors in directory blocks Dave Chinner
2014-04-21 7:08 ` Christoph Hellwig
2014-04-15 8:24 ` [PATCH 5/9] repair: detect CRC errors in AG headers Dave Chinner
2014-04-15 19:40 ` Brian Foster
2014-04-15 21:52 ` Dave Chinner
2014-04-21 7:11 ` Christoph Hellwig
2014-04-21 23:35 ` Dave Chinner
2014-04-22 6:47 ` Christoph Hellwig
2014-04-22 9:10 ` Dave Chinner
2014-04-22 9:41 ` Christoph Hellwig
2014-04-15 8:24 ` [PATCH 6/9] repair: report AG btree verifier errors Dave Chinner
2014-04-15 19:40 ` Brian Foster
2014-04-15 21:53 ` Dave Chinner
2014-04-15 8:24 ` [PATCH 7/9] repair: remove more dirv1 leftovers Dave Chinner
2014-04-16 13:23 ` Brian Foster
2014-04-21 7:14 ` Christoph Hellwig
2014-04-21 7:13 ` Christoph Hellwig
2014-04-15 8:25 ` [PATCH 8/9] repair: handle remote sylmlink CRC errors Dave Chinner
2014-04-16 13:23 ` Brian Foster [this message]
2014-04-15 8:25 ` [PATCH 9/9] repair: detect and handle attribute tree " Dave Chinner
2014-04-16 13:25 ` Brian Foster
2014-04-21 23:27 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416132356.GB4180@laptop.bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).