From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com, Miklos Szeredi <mszeredi@suse.cz>,
Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: [PATCH 2/4] renameat2 syscall: check plain rename
Date: Thu, 17 Apr 2014 09:03:15 +1000 [thread overview]
Message-ID: <20140416230315.GF31578@dastard> (raw)
In-Reply-To: <20140416141825.GA32449@infradead.org>
On Wed, Apr 16, 2014 at 07:18:25AM -0700, Christoph Hellwig wrote:
> On Mon, Apr 14, 2014 at 12:30:20PM +1000, Dave Chinner wrote:
> > IOWs, XFS is returning EEXIST rather than ENOTEMPTY for several of
> > these rename tests. The rename man page says this about the errors:
> >
> > ENOTEMPTY or EEXIST
> > newpath is a nonempty directory, that is, contains
> > entries other than "." and "..".
> >
> > Which implies that both errors are valid and so the test should pass
> > in either case. Can you send a patch to handle these
> > different-but-valid error returns?
>
> I would much prefer if all Linux filesystems behaved uniformly here.
>
> While EEXIST sounds much more logical to me in this case I suspect most
> other filesystems have copy & pasted from ext2, and we should switch to
> ENOTEMPTY as well.
Send patches, please.
But from an xfstests perspective, we still have to support kernels
and filesystems that return EEXIST for this function, as it is
valid for them to do so....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-04-16 23:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 15:51 [PATCH 1/4] renameat2 syscall: add infrastructure Miklos Szeredi
2014-04-11 15:51 ` [PATCH 2/4] renameat2 syscall: check plain rename Miklos Szeredi
2014-04-14 2:30 ` Dave Chinner
2014-04-16 14:18 ` Christoph Hellwig
2014-04-16 23:03 ` Dave Chinner [this message]
2014-04-11 15:51 ` [PATCH 3/4] renameat2 syscall: check noreplace rename Miklos Szeredi
2014-04-11 15:51 ` [PATCH 4/4] renameat2 syscall: check cross rename Miklos Szeredi
2014-04-11 23:23 ` [PATCH 1/4] renameat2 syscall: add infrastructure Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416230315.GF31578@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=miklos@szeredi.hu \
--cc=mszeredi@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox