From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 222CE29DF7 for ; Mon, 21 Apr 2014 15:37:01 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id D1E9E8F8064 for ; Mon, 21 Apr 2014 13:37:00 -0700 (PDT) Received: from mail-yh0-f43.google.com (mail-yh0-f43.google.com [209.85.213.43]) by cuda.sgi.com with ESMTP id Hcy07Kwp2Aet3DqD (version=TLSv1 cipher=RC4-SHA bits=128 verify=NO) for ; Mon, 21 Apr 2014 13:36:59 -0700 (PDT) Received: by mail-yh0-f43.google.com with SMTP id b6so3979503yha.16 for ; Mon, 21 Apr 2014 13:36:58 -0700 (PDT) Date: Mon, 21 Apr 2014 16:36:55 -0400 From: Eric Whitney Subject: Re: [PATCH] generic: fix check for zero range support in generic/009 Message-ID: <20140421203655.GA960@wallace> References: <20140419190524.GA2116@wallace> <20140420005645.GB15995@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140420005645.GB15995@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: linux-ext4@vger.kernel.org, xfs@oss.sgi.com, Eric Whitney * Dave Chinner : > On Sat, Apr 19, 2014 at 03:05:24PM -0400, Eric Whitney wrote: > > Generic/001 fails when run on a file system that does not support byte range > > zeroing. For example, an EOPNOTSUPP failure occurs when the test is run > > on a pre-3.15 extent-mapped file system. The code in the test intended > > to prevent this contains an apparent typo that results in a check for > > fallocate() rather than zero range support. > > > > Signed-off-by: Eric Whitney > > --- > > tests/generic/009 | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/generic/009 b/tests/generic/009 > > index b7b0b3f..65abe3c 100644 > > --- a/tests/generic/009 > > +++ b/tests/generic/009 > > @@ -44,7 +44,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15 > > > > # real QA test starts here > > _supported_os Linux > > -_require_xfs_io_falloc "fzero" > > +_require_xfs_io_command "fzero" > > There should be a helper in common/rc for this. i.e. > _require_xfs_io_fzero. There's helpers for everything else. Can you > add the helper and wire the tests up to it properly? > Sure. For naming consistency with the other related helper functions, it looks like we'd want to call this _require_xfs_io_falloc_zero(). I'm happy to change this if I'm mistaken. Patches on the way. Thanks, Eric _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs