From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id E852129DF7 for ; Mon, 21 Apr 2014 15:43:14 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id BAAE58F804B for ; Mon, 21 Apr 2014 13:43:14 -0700 (PDT) Received: from mail-yk0-f172.google.com (mail-yk0-f172.google.com [209.85.160.172]) by cuda.sgi.com with ESMTP id S1hdLBEowlqKLa0P (version=TLSv1 cipher=RC4-SHA bits=128 verify=NO) for ; Mon, 21 Apr 2014 13:43:13 -0700 (PDT) Received: by mail-yk0-f172.google.com with SMTP id 200so3848407ykr.31 for ; Mon, 21 Apr 2014 13:43:13 -0700 (PDT) Date: Mon, 21 Apr 2014 16:43:09 -0400 From: Eric Whitney Subject: [PATCH v2 2/3] ext4: fix check for zero range support in ext4/001 Message-ID: <20140421204309.GC960@wallace> MIME-Version: 1.0 Content-Disposition: inline List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: xfs@oss.sgi.com Cc: linux-ext4@vger.kernel.org Ext4/001 fails when run on a file system that does not support byte range zeroing. For example, an EOPNOTSUPP failure occurs when the test is run on a pre-3.15 extent-mapped file system. The code in the test intended to prevent this contains an apparent typo that results in a check for fallocate() rather than zero range support. v2: Use new wrapper function for the check. Signed-off-by: Eric Whitney --- tests/ext4/001 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ext4/001 b/tests/ext4/001 index d575d9a..8239f0e 100755 --- a/tests/ext4/001 +++ b/tests/ext4/001 @@ -45,7 +45,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15 # real QA test starts here _supported_fs ext4 _supported_os Linux -_require_xfs_io_falloc "fzero" +_require_xfs_io_falloc_zero testfile=$TEST_DIR/001.$$ -- 1.8.3.2 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs