From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/9] db: don't claim unchecked CRCs are correct
Date: Tue, 22 Apr 2014 09:13:08 +1000 [thread overview]
Message-ID: <20140421231308.GB18672@dastard> (raw)
In-Reply-To: <20140421070009.GC20384@infradead.org>
On Mon, Apr 21, 2014 at 12:00:09AM -0700, Christoph Hellwig wrote:
> > + switch (iocur_crc_valid()) {
> > + case -1:
> > + ok = "unchecked";
> > + break;
> > + case 0:
> > + ok = "bad";
> > + break;
> > + case 1:
> > + ok = "correct";
> > + break;
> > + default:
> > + ok = "unknown state";
> > + break;
> > + }
>
> We should have symbolic constants for these return values. But then
> again iocur_crc_valid only has a single caller currently, is it even
> worth the effort, or should we simply inline it?
If we grow another user, I'll add an enum for it...
> Otherwise looks good,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-04-21 23:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 8:24 [PATCH 0/9] xfs_db, xfs_repair: improve CRC error detection Dave Chinner
2014-04-15 8:24 ` [PATCH 1/9] db: don't claim unchecked CRCs are correct Dave Chinner
2014-04-21 7:00 ` Christoph Hellwig
2014-04-21 23:13 ` Dave Chinner [this message]
2014-04-15 8:24 ` [PATCH 2/9] db: verify buffer on type change Dave Chinner
2014-04-21 7:02 ` Christoph Hellwig
2014-04-21 23:14 ` Dave Chinner
2014-04-15 8:24 ` [PATCH 3/9] repair: ensure prefetched buffers have CRCs validated Dave Chinner
2014-04-15 19:40 ` Brian Foster
2014-04-15 21:46 ` Dave Chinner
2014-04-15 22:06 ` Brian Foster
2014-04-16 0:41 ` Dave Chinner
2014-04-15 8:24 ` [PATCH 4/9] repair: detect and correct CRC errors in directory blocks Dave Chinner
2014-04-21 7:08 ` Christoph Hellwig
2014-04-15 8:24 ` [PATCH 5/9] repair: detect CRC errors in AG headers Dave Chinner
2014-04-15 19:40 ` Brian Foster
2014-04-15 21:52 ` Dave Chinner
2014-04-21 7:11 ` Christoph Hellwig
2014-04-21 23:35 ` Dave Chinner
2014-04-22 6:47 ` Christoph Hellwig
2014-04-22 9:10 ` Dave Chinner
2014-04-22 9:41 ` Christoph Hellwig
2014-04-15 8:24 ` [PATCH 6/9] repair: report AG btree verifier errors Dave Chinner
2014-04-15 19:40 ` Brian Foster
2014-04-15 21:53 ` Dave Chinner
2014-04-15 8:24 ` [PATCH 7/9] repair: remove more dirv1 leftovers Dave Chinner
2014-04-16 13:23 ` Brian Foster
2014-04-21 7:14 ` Christoph Hellwig
2014-04-21 7:13 ` Christoph Hellwig
2014-04-15 8:25 ` [PATCH 8/9] repair: handle remote sylmlink CRC errors Dave Chinner
2014-04-16 13:23 ` Brian Foster
2014-04-15 8:25 ` [PATCH 9/9] repair: detect and handle attribute tree " Dave Chinner
2014-04-16 13:25 ` Brian Foster
2014-04-21 23:27 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2014-04-24 5:01 [PATCH 0/9 V2] xfs_db, xfs_repair: improve CRC error detection Dave Chinner
2014-04-24 5:01 ` [PATCH 1/9] db: don't claim unchecked CRCs are correct Dave Chinner
2014-04-28 21:04 [PATCH 0/9 v3] xfs_db, xfs_repair: improve CRC error detection Dave Chinner
2014-04-28 21:04 ` [PATCH 1/9] db: don't claim unchecked CRCs are correct Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140421231308.GB18672@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).