From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 09D947F3F for ; Tue, 22 Apr 2014 01:27:42 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id EC1CD8F804B for ; Mon, 21 Apr 2014 23:27:38 -0700 (PDT) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id AqwKVzDrBbunZxiD (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 21 Apr 2014 23:27:37 -0700 (PDT) Date: Mon, 21 Apr 2014 23:27:36 -0700 From: Christoph Hellwig Subject: Re: [PATCH] xfs: bulletfproof xfs_qm_scall_trunc_qfiles() Message-ID: <20140422062736.GA31337@infradead.org> References: <53558354.5040309@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <53558354.5040309@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs-oss On Mon, Apr 21, 2014 at 03:45:08PM -0500, Eric Sandeen wrote: > Coverity noticed that if we sent junk into > xfs_qm_scall_trunc_qfiles(), we could get back an > uninitialized error value. So sanitize the flags we > will accept, and initialize error anyway for good measure. > > (This bug may have been introduced via c61a9e39). > > Should resolve Coverity CID 1163872. > > Signed-off-by: Eric Sandeen Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs