From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v3 00/20] xfsprogs: introduce the free inode btree
Date: Wed, 23 Apr 2014 16:02:32 -0400 [thread overview]
Message-ID: <20140423200232.GG5225@bfoster.bfoster> (raw)
In-Reply-To: <20140423063559.GQ15995@dastard>
On Wed, Apr 23, 2014 at 04:35:59PM +1000, Dave Chinner wrote:
> On Thu, Apr 10, 2014 at 12:10:50PM -0400, Brian Foster wrote:
> > Hi all,
> >
> > This is the v3 userspace portion of finobt support corresponding to v5
> > of the kernel series.
> >
> > Patches 1-10 are straight application of the corresponding kernel patches
> > with omissions where appropriate.
>
> I haven't done anything more than passed a quick eye over them and
> tested them. I'll review them fully in the kernel context, and we
> can apply any changes to the kernel code directly to them...
>
Ok...
> > Patch 11 adds mkfs support. Patches 12 and 13 provide a couple minor db
> > and repair fixes to support the new agi fields and calculate the fs
> > format respectively. Patches 14-18 add real repair support for the
> > finobt. Patch 19 adds support to report finobt state in xfs_info. Patch
> > 20 adds support for metadump.
> >
> > Thoughts, reviews, flames appreciated.
>
> I've made comments on the patches that i think need a bit of work,
> but all the remainder (11-20) I haven't made any direct comment on
> you can consider:
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
>
Sounds good. Thanks for the reviews! :)
Brian
> --
> Dave Chinner
> david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-04-23 20:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 16:10 [PATCH v3 00/20] xfsprogs: introduce the free inode btree Brian Foster
2014-04-10 16:10 ` [PATCH v3 01/20] xfs: refactor xfs_ialloc_btree.c to support multiple inobt numbers Brian Foster
2014-04-10 16:10 ` [PATCH v3 02/20] xfs: reserve v5 superblock read-only compat. feature bit for finobt Brian Foster
2014-04-10 16:10 ` [PATCH v3 03/20] xfs: support the XFS_BTNUM_FINOBT free inode btree type Brian Foster
2014-04-10 16:10 ` [PATCH v3 04/20] xfs: update inode allocation/free transaction reservations for finobt Brian Foster
2014-04-10 16:10 ` [PATCH v3 05/20] xfs: insert newly allocated inode chunks into the finobt Brian Foster
2014-04-10 16:10 ` [PATCH v3 06/20] xfs: use and update the finobt on inode allocation Brian Foster
2014-04-10 16:10 ` [PATCH v3 07/20] xfs: refactor xfs_difree() inobt bits into xfs_difree_inobt() helper Brian Foster
2014-04-10 16:10 ` [PATCH v3 08/20] xfs: update the finobt on inode free Brian Foster
2014-04-10 16:10 ` [PATCH v3 09/20] xfs: report finobt status in fs geometry Brian Foster
2014-04-10 16:11 ` [PATCH v3 10/20] xfs: enable the finobt feature on v5 superblocks Brian Foster
2014-04-10 16:11 ` [PATCH v3 11/20] xfsprogs/mkfs: finobt mkfs support Brian Foster
2014-04-23 6:03 ` Dave Chinner
2014-04-23 20:01 ` Brian Foster
2014-04-10 16:11 ` [PATCH v3 12/20] xfsprogs/db: finobt support Brian Foster
2014-04-10 16:11 ` [PATCH v3 13/20] xfsprogs/repair: account for finobt in ag 0 geometry pre-calculation Brian Foster
2014-04-23 6:12 ` Dave Chinner
2014-04-23 20:02 ` Brian Foster
2014-04-23 22:53 ` Dave Chinner
2014-04-10 16:11 ` [PATCH v3 14/20] xfsprogs/repair: phase 2 finobt scan Brian Foster
2014-04-23 6:10 ` Dave Chinner
2014-04-23 6:19 ` Dave Chinner
2014-04-23 20:01 ` Brian Foster
2014-04-23 23:06 ` Dave Chinner
2014-04-24 0:39 ` Brian Foster
2014-04-10 16:11 ` [PATCH v3 15/20] xfsprogs/repair: pass btree block magic as param to build_ino_tree() Brian Foster
2014-04-10 16:11 ` [PATCH v3 16/20] xfsprogs/repair: pull the build_agi() call up out of the inode tree build Brian Foster
2014-04-10 16:11 ` [PATCH v3 17/20] xfsprogs/repair: helpers for finding in-core inode records w/ free inodes Brian Foster
2014-04-23 6:24 ` Dave Chinner
2014-04-23 20:02 ` Brian Foster
2014-04-23 22:58 ` Dave Chinner
2014-04-10 16:11 ` [PATCH v3 18/20] xfsprogs/repair: reconstruct the finobt in phase 5 Brian Foster
2014-04-10 16:11 ` [PATCH v3 19/20] xfsprogs/growfs: report finobt status in fs geometry (xfs_info) Brian Foster
2014-04-10 16:11 ` [PATCH v3 20/20] xfsprogs/db: add finobt support to metadump Brian Foster
2014-04-23 6:35 ` [PATCH v3 00/20] xfsprogs: introduce the free inode btree Dave Chinner
2014-04-23 20:02 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423200232.GG5225@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).