From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/6] xfs: introduce new large ACL test
Date: Thu, 24 Apr 2014 09:09:15 +1000 [thread overview]
Message-ID: <20140423230915.GV15995@dastard> (raw)
In-Reply-To: <20140423152313.GC26128@infradead.org>
On Wed, Apr 23, 2014 at 08:23:13AM -0700, Christoph Hellwig wrote:
> On Wed, Apr 23, 2014 at 08:04:31AM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Having just removed the largeacl test from the shared ACL test,
> > reintroduce the same test as an XFS specific test so that we can
> > handle the different limits in supported ACL count appropriately.
>
> I'd prefer to have this as a shared test, and define a _max_acl_size
> function in common.acl that does a switch for the fs type. Only
> start with XFS for now, but if the maintainers of other filesystems
> care enough they could add their limits.
Ok, I'll add it as a generic test, along with a _max_acl_size
function and a _requires_max_acl_size helper....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-04-23 23:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 22:04 [PATCH 0/6] xfstests: fixes and new tests Dave Chinner
2014-04-22 22:04 ` [PATCH 1/6] generic/204: tweak reserve pool size Dave Chinner
2014-04-23 15:21 ` Christoph Hellwig
2014-04-22 22:04 ` [PATCH 2/6] shared/051: remove ACL count subtest Dave Chinner
2014-04-23 15:21 ` Christoph Hellwig
2014-04-22 22:04 ` [PATCH 3/6] xfs: introduce new large ACL test Dave Chinner
2014-04-23 15:23 ` Christoph Hellwig
2014-04-23 23:09 ` Dave Chinner [this message]
2014-04-23 23:44 ` [PATCH 3/6 v2] generic: " Dave Chinner
2014-04-25 5:36 ` Christoph Hellwig
2014-04-22 22:04 ` [PATCH 4/6] generic: cleanup space after test in TESTDIR Dave Chinner
2014-04-23 15:23 ` Christoph Hellwig
2014-04-22 22:04 ` [PATCH 5/6] xfs: remove dmapi tests from the auto group Dave Chinner
2014-04-23 15:24 ` Christoph Hellwig
2014-04-22 22:04 ` [PATCH 6/6] filter: xfs_repair emits new corruption messagse Dave Chinner
2014-04-23 15:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423230915.GV15995@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).