From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 5/9] repair: detect CRC errors in AG headers
Date: Thu, 24 Apr 2014 22:55:16 -0700 [thread overview]
Message-ID: <20140425055516.GC30118@infradead.org> (raw)
In-Reply-To: <1398315722-20870-6-git-send-email-david@fromorbit.com>
> sb = (xfs_sb_t *)calloc(BBSIZE, 1);
If you already do various cosmetic changes I'd recommend removing the
useles case here as well.
> - if (status & XR_AG_AGF) {
> + if (agf_dirty || status & XR_AG_AGF) {
> - if (status & XR_AG_AGI) {
> + if (agi_dirty || status & XR_AG_AGI) {
I can't see how agf_dirty and agi_dirty would ever be set at this point.
> +out_free:
> + if (sb)
> + free(sb);
> + if (agibuf)
> + libxfs_putbuf(agibuf);
> + if (agfbuf)
> + libxfs_putbuf(agfbuf);
> + if (sbbuf)
> + libxfs_putbuf(sbbuf);
> + if (objname)
> + do_error(_("can't get %s for ag %d\n"), objname, agno);
> + return;
No need for a return statement at the end of a void returning function.
Also any reason for not using one goto for each unwind step like we do
elsewhere instead of the if (!NULL) checks?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-04-25 5:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 5:01 [PATCH 0/9 V2] xfs_db, xfs_repair: improve CRC error detection Dave Chinner
2014-04-24 5:01 ` [PATCH 1/9] db: don't claim unchecked CRCs are correct Dave Chinner
2014-04-24 5:01 ` [PATCH 2/9] db: verify buffer on type change Dave Chinner
2014-04-25 5:41 ` Christoph Hellwig
2014-04-24 5:01 ` [PATCH 3/9] repair: ensure prefetched buffers have CRCs validated Dave Chinner
2014-04-25 5:47 ` Christoph Hellwig
2014-04-24 5:01 ` [PATCH 4/9] repair: detect and correct CRC errors in directory blocks Dave Chinner
2014-04-25 5:47 ` Christoph Hellwig
2014-04-24 5:01 ` [PATCH 5/9] repair: detect CRC errors in AG headers Dave Chinner
2014-04-25 5:55 ` Christoph Hellwig [this message]
2014-04-24 5:01 ` [PATCH 6/9] repair: report AG btree verifier errors Dave Chinner
2014-04-25 5:55 ` Christoph Hellwig
2014-04-24 5:02 ` [PATCH 7/9] repair: remove more dirv1 leftovers Dave Chinner
2014-04-24 5:02 ` [PATCH 8/9] repair: handle remote symlink CRC errors Dave Chinner
2014-04-25 6:01 ` Christoph Hellwig
2014-04-24 5:02 ` [PATCH 9/9] repair: detect and handle attribute tree " Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2014-04-28 21:04 [PATCH 0/9 v3] xfs_db, xfs_repair: improve CRC error detection Dave Chinner
2014-04-28 21:04 ` [PATCH 5/9] repair: detect CRC errors in AG headers Dave Chinner
2014-04-29 14:06 ` Brian Foster
2014-05-01 23:27 ` Dave Chinner
2014-04-29 18:16 ` Christoph Hellwig
2014-04-15 8:24 [PATCH 0/9] xfs_db, xfs_repair: improve CRC error detection Dave Chinner
2014-04-15 8:24 ` [PATCH 5/9] repair: detect CRC errors in AG headers Dave Chinner
2014-04-15 19:40 ` Brian Foster
2014-04-15 21:52 ` Dave Chinner
2014-04-21 7:11 ` Christoph Hellwig
2014-04-21 23:35 ` Dave Chinner
2014-04-22 6:47 ` Christoph Hellwig
2014-04-22 9:10 ` Dave Chinner
2014-04-22 9:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425055516.GC30118@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).